From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: kostja@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] Fix type aliases in SQL
Date: Tue, 30 Jul 2019 17:21:24 +0300 [thread overview]
Message-ID: <20190730142124.5k7hkuzjh33onply@tarantool.org> (raw)
In-Reply-To: <cover.1564437728.git.korablev@tarantool.org>
Hello,
On 30 Jul 02:34, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/sql-type-aliases
>
> Justification is described in commit messages, but the main
> point is to make NoSQL type system be consistent with SQL one
> at least in types naming.
>
> The only concern I've noticed: CAST to NUMBER always results in
> coversion of integer or string literal to floating point value.
> Meanwhile, number can hold integer values. So the question is
> should CAST("integer_literal" AS NUMBER) return floating point,
> or just be no-op in this case...?
>
> Nikita Pettik (2):
> sql: add STRING alias to TEXT type
> sql: rename REAL/FLOAT/DOUBLE types to NUMBER
I've checked the patchset into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-07-30 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 23:34 [tarantool-patches] " Nikita Pettik
2019-07-29 23:34 ` [tarantool-patches] [PATCH 1/2] sql: add STRING alias to TEXT type Nikita Pettik
2019-07-30 7:18 ` [tarantool-patches] " Konstantin Osipov
2019-07-30 7:19 ` Konstantin Osipov
2019-07-29 23:34 ` [tarantool-patches] [PATCH 2/2] sql: rename REAL/FLOAT/DOUBLE types to NUMBER Nikita Pettik
2019-07-30 7:21 ` [tarantool-patches] " Konstantin Osipov
2019-07-30 14:21 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730142124.5k7hkuzjh33onply@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 0/2] Fix type aliases in SQL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox