From: Konstantin Osipov <kostja@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: rename REAL/FLOAT/DOUBLE types to NUMBER
Date: Tue, 30 Jul 2019 10:21:25 +0300 [thread overview]
Message-ID: <20190730072125.GC7799@atlas> (raw)
In-Reply-To: <ef94ce26cf07f200804ec24e8aa08344649b42a9.1564437728.git.korablev@tarantool.org>
* Nikita Pettik <korablev@tarantool.org> [19/07/30 09:41]:
> Before this patch it was allowed to specify REAL/FLOAT/DOUBLE types
> which matched with NUMBER NoSQL type in space format. However, NUMBER is
> different from standard floating point types, since it is able to hold
> integers in range [-2^63; 2^64-1] alongside with double precision
> floating point values. Hence, to not confuse users it has been decided
> to remove support of REAL/FLOAT/DOUBLE types from SQL grammar and use
> instead original NUMBER type naming.
This is a breaking change as some people are using 2.x.
Says a lot about the maturity of 2.x, eh...
LGTM.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-30 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 23:34 [tarantool-patches] [PATCH 0/2] Fix type aliases in SQL Nikita Pettik
2019-07-29 23:34 ` [tarantool-patches] [PATCH 1/2] sql: add STRING alias to TEXT type Nikita Pettik
2019-07-30 7:18 ` [tarantool-patches] " Konstantin Osipov
2019-07-30 7:19 ` Konstantin Osipov
2019-07-29 23:34 ` [tarantool-patches] [PATCH 2/2] sql: rename REAL/FLOAT/DOUBLE types to NUMBER Nikita Pettik
2019-07-30 7:21 ` Konstantin Osipov [this message]
2019-07-30 14:21 ` [tarantool-patches] Re: [PATCH 0/2] Fix type aliases in SQL Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730072125.GC7799@atlas \
--to=kostja@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 2/2] sql: rename REAL/FLOAT/DOUBLE types to NUMBER' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox