Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH] txn: convert txn flags into bit mask
Date: Mon, 29 Jul 2019 18:37:54 +0300	[thread overview]
Message-ID: <20190729153754.GA26958@atlas> (raw)
In-Reply-To: <20190729123002.GE4659@esperanza>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/29 15:33]:
> On Mon, Jul 29, 2019 at 03:14:11PM +0300, Konstantin Osipov wrote:
> > * Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/29 13:56]:
> > > ---
> > > https://github.com/tarantool/tarantool/commits/dv/txn-flags
> > 
> > Curious, why not use bit fields?

I will read the article, I do not have a strong opinion, it's just
checking for bit flags using an enum looks a bit clumsy, how about 
a bit of syntax sugar like
txn_has_flag(txn, FLAG), tnx_set_flag(txn, FLAG),
txn_clear_flag(txn, FLAG).

What do you think?


-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2019-07-29 15:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 10:52 Vladimir Davydov
2019-07-29 12:14 ` [tarantool-patches] " Konstantin Osipov
2019-07-29 12:30   ` Vladimir Davydov
2019-07-29 15:37     ` Konstantin Osipov [this message]
2019-07-30  7:58       ` Vladimir Davydov
2019-07-30 10:21         ` Konstantin Osipov
2019-07-30 10:27           ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190729153754.GA26958@atlas \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] Re: [PATCH] txn: convert txn flags into bit mask' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox