From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH] txn: convert txn flags into bit mask
Date: Mon, 29 Jul 2019 15:30:02 +0300 [thread overview]
Message-ID: <20190729123002.GE4659@esperanza> (raw)
In-Reply-To: <20190729121410.GA16601@atlas>
On Mon, Jul 29, 2019 at 03:14:11PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/29 13:56]:
> > ---
> > https://github.com/tarantool/tarantool/commits/dv/txn-flags
>
> Curious, why not use bit fields?
Personally I don't like bit fields, because AFAIK the way they are
stored, accessed and updated depends on the compiler and, possibly,
the underlying architercture. There might be some unexpected side
effects, e.g. see
https://lwn.net/Articles/478657/
If you prefer bit fields, no problem, I will change the patch as
you like.
next prev parent reply other threads:[~2019-07-29 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 10:52 Vladimir Davydov
2019-07-29 12:14 ` [tarantool-patches] " Konstantin Osipov
2019-07-29 12:30 ` Vladimir Davydov [this message]
2019-07-29 15:37 ` Konstantin Osipov
2019-07-30 7:58 ` Vladimir Davydov
2019-07-30 10:21 ` Konstantin Osipov
2019-07-30 10:27 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729123002.GE4659@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re: [PATCH] txn: convert txn flags into bit mask' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox