From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/2] sql: extend struct Mem with field_type member
Date: Mon, 29 Jul 2019 00:26:17 +0300 [thread overview]
Message-ID: <20190728212617.GC18418@atlas> (raw)
In-Reply-To: <8be21965-b8ef-4f96-8ce3-99c2efcecfc0@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/07/28 21:49]:
> > const char *z = 0;
> > UNUSED_PARAMETER(NotUsed);
> > + enum field_type f_t = argv[0]->field_type;
>
> 1. Perhaps, field_type is not the best name, because Mem is not always
> is a field. It can be just a value, not from a space. It is rather
> just 'type'.
>
I think field_type is good because it's clear it's derived from
enum field_type. Mem has more than one type now, so just "type" is
ambiguous. My 0.02
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-28 21:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 18:45 [tarantool-patches] [PATCH 0/2] Improve operability of typeof() function Nikita Pettik
2019-07-27 18:45 ` [tarantool-patches] [PATCH 1/2] sql: extend struct Mem with field_type member Nikita Pettik
2019-07-28 15:22 ` [tarantool-patches] " Vladislav Shpilevoy
2019-07-28 21:26 ` Konstantin Osipov [this message]
2019-07-31 9:14 ` n.pettik
2019-07-31 16:59 ` Vladislav Shpilevoy
2019-08-01 15:56 ` n.pettik
2019-08-01 23:11 ` Vladislav Shpilevoy
2019-08-02 10:02 ` n.pettik
2019-07-27 18:45 ` [tarantool-patches] [PATCH 2/2] sql: make default type of NULL be boolean Nikita Pettik
2019-08-02 10:52 ` [tarantool-patches] Re: [PATCH 0/2] Improve operability of typeof() function Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728212617.GC18418@atlas \
--to=kostja@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/2] sql: extend struct Mem with field_type member' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox