From: Konstantin Osipov <kostja@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/3] box/console: Don't allow arguments in get_default_output
Date: Sun, 28 Jul 2019 21:44:22 +0300 [thread overview]
Message-ID: <20190728184422.GA13676@atlas> (raw)
In-Reply-To: <20190726221712.11191-2-gorcunov@gmail.com>
* Cyrill Gorcunov <gorcunov@gmail.com> [19/07/27 01:21]:
> -local function get_default_output()
> +local function get_default_output(...)
> + local args = ...
I think it's enough to check for a single argument, variadic
arguments introduce unnecessary overhead.
> + if args ~= nil then
> + error("Arguments provided while prohibited")
error("This function accepts no arguments")
> + end
> return default_output_format
> end
Please add a test case.
Otherwise lgtm.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-28 18:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 22:17 [tarantool-patches] [PATCH 0/3] box/console: Cleanup and bug fix Cyrill Gorcunov
2019-07-26 22:17 ` [tarantool-patches] [PATCH 1/3] box/console: Don't allow arguments in get_default_output Cyrill Gorcunov
2019-07-28 18:44 ` Konstantin Osipov [this message]
2019-07-28 21:43 ` [tarantool-patches] " Cyrill Gorcunov
2019-07-26 22:17 ` [tarantool-patches] [PATCH 2/3] box/console: Drop redundant status parameter from return Cyrill Gorcunov
2019-07-28 18:44 ` [tarantool-patches] " Konstantin Osipov
2019-07-26 22:17 ` [tarantool-patches] [PATCH 3/3] box/console: Test for nil value in args directly Cyrill Gorcunov
2019-07-28 18:46 ` [tarantool-patches] " Konstantin Osipov
2019-07-28 18:47 ` Konstantin Osipov
2019-07-28 21:42 ` Cyrill Gorcunov
2019-08-02 12:59 ` [tarantool-patches] Re: [PATCH 0/3] box/console: Cleanup and bug fix Kirill Yukhin
2019-08-02 13:26 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728184422.GA13676@atlas \
--to=kostja@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/3] box/console: Don'\''t allow arguments in get_default_output' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox