From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@freelists.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
Konstantin Osipov <kostja@tarantool.org>,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [tarantool-patches] [PATCH 1/3] box/console: Don't allow arguments in get_default_output
Date: Sat, 27 Jul 2019 01:17:10 +0300 [thread overview]
Message-ID: <20190726221712.11191-2-gorcunov@gmail.com> (raw)
In-Reply-To: <20190726221712.11191-1-gorcunov@gmail.com>
The function
| require('console').get_default_output()
requires no arguments. Make it explcicit and print
an error otherwise.
Part-of #3834
---
src/box/lua/console.lua | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/box/lua/console.lua b/src/box/lua/console.lua
index d4f61865c..9258e7bbb 100644
--- a/src/box/lua/console.lua
+++ b/src/box/lua/console.lua
@@ -115,7 +115,11 @@ local function set_default_output(value)
default_output_format["opts"] = opts
end
-local function get_default_output()
+local function get_default_output(...)
+ local args = ...
+ if args ~= nil then
+ error("Arguments provided while prohibited")
+ end
return default_output_format
end
--
2.20.1
next prev parent reply other threads:[~2019-07-26 22:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 22:17 [tarantool-patches] [PATCH 0/3] box/console: Cleanup and bug fix Cyrill Gorcunov
2019-07-26 22:17 ` Cyrill Gorcunov [this message]
2019-07-28 18:44 ` [tarantool-patches] Re: [PATCH 1/3] box/console: Don't allow arguments in get_default_output Konstantin Osipov
2019-07-28 21:43 ` Cyrill Gorcunov
2019-07-26 22:17 ` [tarantool-patches] [PATCH 2/3] box/console: Drop redundant status parameter from return Cyrill Gorcunov
2019-07-28 18:44 ` [tarantool-patches] " Konstantin Osipov
2019-07-26 22:17 ` [tarantool-patches] [PATCH 3/3] box/console: Test for nil value in args directly Cyrill Gorcunov
2019-07-28 18:46 ` [tarantool-patches] " Konstantin Osipov
2019-07-28 18:47 ` Konstantin Osipov
2019-07-28 21:42 ` Cyrill Gorcunov
2019-08-02 12:59 ` [tarantool-patches] Re: [PATCH 0/3] box/console: Cleanup and bug fix Kirill Yukhin
2019-08-02 13:26 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726221712.11191-2-gorcunov@gmail.com \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH 1/3] box/console: Don'\''t allow arguments in get_default_output' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox