Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH small 2/2] rlist: add cut and reverse methods
Date: Fri, 26 Jul 2019 22:24:49 +0300	[thread overview]
Message-ID: <20190726192449.GA14622@atlas> (raw)
In-Reply-To: <20190725143143.GO24631@esperanza>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/25 17:36]:

The tests for both functions should cover an empty list and a list
with 1 element.

Otherwise lgtm.


-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2019-07-26 19:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19 17:59 [PATCH small 0/2] small: add new rlist helpers Vladimir Davydov
2019-07-19 17:59 ` [PATCH small 1/2] rlist: add unit test Vladimir Davydov
2019-07-19 17:59 ` [PATCH small 2/2] rlist: add cut and reverse methods Vladimir Davydov
2019-07-25 14:31   ` Vladimir Davydov
2019-07-26 19:24     ` Konstantin Osipov [this message]
2019-07-19 18:53 ` [tarantool-patches] Re: [PATCH small 0/2] small: add new rlist helpers Konstantin Osipov
2019-07-19 19:40   ` Vladimir Davydov
2019-07-24 15:04     ` Konstantin Osipov
2019-07-29  8:40 ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190726192449.GA14622@atlas \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH small 2/2] rlist: add cut and reverse methods' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox