From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org, v.shpilevoy@tarantool.org
Subject: Re: [PATCH v5 3/3] box: introduce func_index
Date: Fri, 26 Jul 2019 12:57:43 +0300 [thread overview]
Message-ID: <20190726095743.GG9916@atlas> (raw)
In-Reply-To: <20190726094958.GA4080@esperanza>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/26 12:54]:
>
> There's one thing about _func_index space that keeps bothering me: since
> insertion of a tuple into this space is a yielding operation and this
> operation is executed after insertion of a tuple into _index, we won't
> be able to wrap space.create_index() into box.begin/commit, because only
> the first DDL statement in a transaction is allowed to be yielding.
I think we agreed to solve this to build func index at recovery
in _func_index trigger and at create in _func trigger.
Let's work on a follow up patch right away.
>
> I assume that it's not important, because the corresponding ticket
> (#4348) is scheduled for 2.3 so we will probably figure something out
> until then (may be, implement support of yielding statements in DDL).
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-26 9:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 18:39 [PATCH v5 0/3] box: functional indexes Kirill Shcherbatov
2019-07-25 18:39 ` [PATCH v5 1/3] box: introduce opts.is_multikey function option Kirill Shcherbatov
2019-07-26 9:22 ` Vladimir Davydov
2019-07-26 9:55 ` Konstantin Osipov
2019-07-25 18:39 ` [PATCH v5 2/3] box: introduce tuple_chunk infrastructure Kirill Shcherbatov
2019-07-26 9:35 ` Vladimir Davydov
2019-07-25 18:39 ` [PATCH v5 3/3] box: introduce func_index Kirill Shcherbatov
2019-07-26 9:49 ` Vladimir Davydov
2019-07-26 9:57 ` Konstantin Osipov [this message]
2019-07-26 10:10 ` Vladimir Davydov
2019-07-26 19:31 ` [tarantool-patches] " Konstantin Osipov
2019-07-27 11:42 ` Vladimir Davydov
2019-07-28 21:30 ` Konstantin Osipov
2019-07-26 9:43 [PATCH v5 0/3] box: functional indexes Kirill Shcherbatov
2019-07-26 9:43 ` [PATCH v5 3/3] box: introduce func_index Kirill Shcherbatov
2019-07-26 12:15 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726095743.GG9916@atlas \
--to=kostja@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v5 3/3] box: introduce func_index' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox