[tarantool-patches] Re: [PATCH 1/3] vinyl: use update_def index method to update vy_lsm on ddl

[Konstantin Osipov <kostja@tarantool.org>]

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/23 18:49]:
> When an index definition is modified by DDL in such a way that doesn't
> require index rebuild (e.g. a key part type is changed from unsigned to
> integer), we move the index from the old space container to the new one,
> see ModifyIndex. In case of Vinyl we also need to update key definitions
> and options stored in vy_lsm. We do that in swap_index space method, but
> this isn't entirely correct, as this method is also called when an index
> is moved without any modifications, see MoveIndex. Let's do this from
> update_def index method instead, which seems to be more suitable.
> 
> The only reason this code lives in swap_index space method now is that
> we didn't have update_def index method when this functionality was
> introduced in the first place.

First of all, it is extremely annoying that instead of testing
this properly despite my humble, repeated requests we waited for
these bugs to surface and now address them with urgent
patches.

I see if I could find anything wrong with this patch but I can't.

> +static struct key_def *
> +key_def_do_copy(struct key_def *res, const struct key_def *src, size_t sz)

I personally prefer _impl to do_.

-- 
Konstantin Osipov, Moscow, Russia