From: Konstantin Osipov <kostja@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org, vdavydov.dev@gmail.com
Subject: Re: [PATCH v4 4/4] box: introduce functional indexes
Date: Wed, 24 Jul 2019 22:41:30 +0300 [thread overview]
Message-ID: <20190724194130.GD7651@atlas> (raw)
In-Reply-To: <e244e92d21226c8a869d9d87987ccc9cf21af803.1563953154.git.kshcherbatov@tarantool.org>
* Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/07/24 10:38]:
I think generally you're on track, and patch needs a careful
review now. Please solicit a review from Vova. For the
tuple_compare part, please ask Vlad to take a look - he did a lot
in this part of the code.
The only issue that surprised me is that you allocate a separate
tuple chunk for each key. I somehow thought that you're going to
use the same chunk for all bps tree entries, which I now realize
is impossible, since you'll need to store a chunk offset somewhere.
The problem is that slab alloc doesn't have a slab for tiny chunks
now - the smallest chunk is 24 bytes.
This is obviously an overkill for this scenario. Please fix the
slab arena accordingly.
There are lots of style comments, I'll place them on the branch.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-24 19:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 7:36 [PATCH v4 0/4] box: " Kirill Shcherbatov
2019-07-24 7:36 ` [PATCH v4 1/4] box: introduce tuple_chunk infrastructure Kirill Shcherbatov
2019-07-24 7:36 ` [PATCH v4 2/4] box: generalize memtx_multikey_tree methods Kirill Shcherbatov
2019-07-24 19:24 ` Konstantin Osipov
2019-07-24 7:36 ` [PATCH v4 3/4] box: refactor memtx_tree_delete_identical Kirill Shcherbatov
2019-07-24 19:24 ` Konstantin Osipov
2019-07-24 7:36 ` [PATCH v4 4/4] box: introduce functional indexes Kirill Shcherbatov
2019-07-24 12:24 ` [tarantool-patches] " Kirill Shcherbatov
2019-07-24 19:41 ` Konstantin Osipov [this message]
2019-07-24 20:04 ` Konstantin Osipov
2019-07-24 20:22 ` Konstantin Osipov
2019-07-25 11:20 ` [tarantool-patches] " Kirill Shcherbatov
2019-07-24 20:44 ` Konstantin Osipov
2019-07-25 11:22 ` [tarantool-patches] " Kirill Shcherbatov
2019-07-24 21:07 ` Konstantin Osipov
2019-07-25 8:27 ` [tarantool-patches] " Kirill Shcherbatov
2019-07-25 8:40 ` Konstantin Osipov
2019-07-25 11:18 ` Kirill Shcherbatov
2019-07-24 21:17 ` Konstantin Osipov
2019-07-24 21:56 ` Konstantin Osipov
2019-07-25 8:33 ` [tarantool-patches] " Kirill Shcherbatov
2019-07-24 12:25 ` [tarantool-patches] [PATCH v4 4/5] box: fix memtx_tree_index_build_array_deduplicate Kirill Shcherbatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724194130.GD7651@atlas \
--to=kostja@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v4 4/4] box: introduce functional indexes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox