Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>,
	Alexander Turenko <alexander.turenko@tarantool.org>,
	Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 5/5] box/lua/console: Limit lua output for local sessions only
Date: Wed, 24 Jul 2019 20:15:37 +0300	[thread overview]
Message-ID: <20190724171537.GE4764@atlas> (raw)
In-Reply-To: <20190723223113.16084-6-gorcunov@gmail.com>

* Cyrill Gorcunov <gorcunov@gmail.com> [19/07/24 01:35]:
> To make full support of lua mode on remote connection we
> need pass this option to remote server. Also we need to
> provide a compatibility layer for servers from previous
> series and thus recode yaml output on client side.
> 
> This will be done in next patches, for now simply limit
> the usage of lua output to local sessions only.
> 
> Part-of #3834
> ---
>  src/box/lua/console.lua | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)

I don't think this patch is necessary, or we need to do anything
about remote consoles. What we have is good enough - remote format
is used. We can simply document it.
Whoever doesn't like the remote format, can change it right after
connecting to the remote.

Not pushing.


-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2019-07-24 17:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 22:31 [tarantool-patches] [PATCH v4 0/5] box/lua/console: Add initial support for lua output format Cyrill Gorcunov
2019-07-23 22:31 ` [tarantool-patches] [PATCH 1/5] third_party/serpent: Add serpent repo Cyrill Gorcunov
2019-07-24 17:02   ` [tarantool-patches] " Konstantin Osipov
2019-07-24 17:33     ` Cyrill Gorcunov
2019-07-23 22:31 ` [tarantool-patches] [PATCH 2/5] box/lua/console: Add support for lua output format Cyrill Gorcunov
2019-07-23 22:31 ` [tarantool-patches] [PATCH 3/5] box/lua/console: Don't serialize function body Cyrill Gorcunov
2019-07-23 22:31 ` [tarantool-patches] [PATCH 4/5] box/lua/console: Provide output_default function to setup default output Cyrill Gorcunov
2019-07-24 17:10   ` [tarantool-patches] " Konstantin Osipov
2019-07-24 17:11     ` Konstantin Osipov
2019-07-24 17:34       ` Cyrill Gorcunov
2019-07-23 22:31 ` [tarantool-patches] [PATCH 5/5] box/lua/console: Limit lua output for local sessions only Cyrill Gorcunov
2019-07-24 17:15   ` Konstantin Osipov [this message]
2019-07-24 17:35     ` [tarantool-patches] " Cyrill Gorcunov
2019-07-24 17:00 ` [tarantool-patches] Re: [PATCH v4 0/5] box/lua/console: Add initial support for lua output format Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190724171537.GE4764@atlas \
    --to=kostja@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 5/5] box/lua/console: Limit lua output for local sessions only' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox