From: Konstantin Osipov <kostja@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: fix type in meta for unsigned binding
Date: Wed, 24 Jul 2019 20:10:07 +0300 [thread overview]
Message-ID: <20190724171007.GB4764@atlas> (raw)
In-Reply-To: <20190724165508.81356-1-korablev@tarantool.org>
* Nikita Pettik <korablev@tarantool.org> [19/07/24 19:59]:
> It was decided that for all integer literals we would return "INTEGER"
> type, not "UNSIGNED". Accidentally, after substitution of unsigned
> binding value type was set to "UNSIGNED". Let's fix that and set
> "INTEGER" type.
the patch is lgtm but I'm not sure it covers all cases.
I've seen a lot of unsigned inthe tests.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-24 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 16:55 [tarantool-patches] " Nikita Pettik
2019-07-24 17:10 ` Konstantin Osipov [this message]
2019-07-24 17:44 ` [tarantool-patches] " n.pettik
2019-07-24 18:23 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724171007.GB4764@atlas \
--to=kostja@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: fix type in meta for unsigned binding' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox