From: Nikita Pettik <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: kostja@tarantool.org, Nikita Pettik <korablev@tarantool.org> Subject: [tarantool-patches] [PATCH] sql: fix type in meta for unsigned binding Date: Wed, 24 Jul 2019 19:55:08 +0300 [thread overview] Message-ID: <20190724165508.81356-1-korablev@tarantool.org> (raw) It was decided that for all integer literals we would return "INTEGER" type, not "UNSIGNED". Accidentally, after substitution of unsigned binding value type was set to "UNSIGNED". Let's fix that and set "INTEGER" type. --- Branch: https://github.com/tarantool/tarantool/tree/np/fix-meta-uint-binding src/box/sql/vdbeapi.c | 2 +- test/sql/iproto.result | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/box/sql/vdbeapi.c b/src/box/sql/vdbeapi.c index ecf1b3601..f5885230b 100644 --- a/src/box/sql/vdbeapi.c +++ b/src/box/sql/vdbeapi.c @@ -1005,7 +1005,7 @@ sql_bind_uint64(struct sql_stmt *stmt, int i, uint64_t value) struct Vdbe *p = (struct Vdbe *) stmt; if (vdbeUnbind(p, i) != 0) return -1; - int rc = sql_bind_type(p, i, "UNSIGNED"); + int rc = sql_bind_type(p, i, "INTEGER"); mem_set_u64(&p->aVar[i - 1], value); return rc; } diff --git a/test/sql/iproto.result b/test/sql/iproto.result index 26d12a51a..9639ba7a6 100644 --- a/test/sql/iproto.result +++ b/test/sql/iproto.result @@ -374,11 +374,11 @@ cn:execute('select $2, $1, $3', parameters) --- - metadata: - name: $2 - type: UNSIGNED + type: INTEGER - name: $1 - type: UNSIGNED + type: INTEGER - name: $3 - type: UNSIGNED + type: INTEGER rows: - [22, 11, 33] ... -- 2.15.1
next reply other threads:[~2019-07-24 16:55 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-24 16:55 Nikita Pettik [this message] 2019-07-24 17:10 ` [tarantool-patches] " Konstantin Osipov 2019-07-24 17:44 ` n.pettik 2019-07-24 18:23 ` Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190724165508.81356-1-korablev@tarantool.org \ --to=korablev@tarantool.org \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH] sql: fix type in meta for unsigned binding' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox