From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: increase row_count when adding CHECK constraint
Date: Wed, 24 Jul 2019 17:10:04 +0300 [thread overview]
Message-ID: <20190724141004.qe7q6saruyf5evyo@tarantool.org> (raw)
In-Reply-To: <5dba4410ecdc97004cd4a9890e302baa20b07529.1563525363.git.imeevma@gmail.com>
Hello,
On 19 Jul 11:38, imeevma@tarantool.org wrote:
> If a CHECK constraint was added using an ALTER TABLE statement,
> row_count should be increased. Note that row_count does not
> increase if a CHECK constraint is added during the execution of a
> CREATE TABLE statement.
> For example:
>
> box.execute('CREATE TABLE t1(id INTEGER PRIMARY KEY);')
> box.execute('ALTER TABLE t1 ADD CONSTRAINT ck1 CHECK(id > 0);')
>
> Should return:
> - row_count: 1
>
> However it was '0' before the patch.
>
> Closes #4363
> ---
> https://github.com/tarantool/tarantool/issues/4363
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4363-increase-row_count-on-alter-table
I've checked your patch into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-07-24 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 8:38 [tarantool-patches] " imeevma
2019-07-22 11:22 ` [tarantool-patches] " n.pettik
2019-07-24 14:10 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724141004.qe7q6saruyf5evyo@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: increase row_count when adding CHECK constraint' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox