[tarantool-patches] Re: [PATCH v4 0/4] sql: do not show IDs generated by trigger

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 17 Jul 12:54, imeevma@tarantool.org wrote:
> Currently, if an INSERT was executed by a trigger during the
> execution of a statement, if there were any generated identifiers,
> they can be displayed as a result of the statement. This is
> incorrect, since we are not able to divide the IDs obtained into
> those that belong to the table mentioned in the statement and
> those that do not belong to this table.
> 
> https://github.com/tarantool/tarantool/issues/4188
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4188-remove-additonal-generated-ids
> 
> Changes in v2:
> 1) Patch was divided into 3 new patches.
> 
> Changes in v3:
> 1) Removed tests in refactoring patch "sql: remove unnecessary
> AUTOINCREMENT ID generation". They shows nothing.
> 2) Changed the way to check that INSERT executed by trigger.
> 3) Fixed a bug with the display of generated AUTOINCREMENT
> identifiers, even if INSERT failed in the case of INSERT OR
> IGNORE.
> 
> Changes in v4:
> 1) Changed the solution for the issue. Now it works without new
> opcode. However, new argument was added to OP_IdxInsert.
> 2) Now the patch in which VDBE does not take into account failed
> inserts becomes practically useless. It has been removed. However,
> a new patch was added that corrects row_count in the specified
> case.
> 
> Mergen Imeev (4):
>   sql: remove unnecessary AUTOINCREMENT ID generation
>   sql: skip autoinc IDs generated inside SQL trigger
>   sql: remove VDBE from TXN
>   sql: do not increase row-count if INSERT or REPLACE failed

I've checked the patch set into master.

--
Regards, Kirill Yukhin