From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v4 0/4] sql: do not show IDs generated by trigger
Date: Wed, 24 Jul 2019 16:55:53 +0300 [thread overview]
Message-ID: <20190724135553.zdk66lf2ohbpokd7@tarantool.org> (raw)
In-Reply-To: <cover.1563356272.git.imeevma@gmail.com>
Hello,
On 17 Jul 12:54, imeevma@tarantool.org wrote:
> Currently, if an INSERT was executed by a trigger during the
> execution of a statement, if there were any generated identifiers,
> they can be displayed as a result of the statement. This is
> incorrect, since we are not able to divide the IDs obtained into
> those that belong to the table mentioned in the statement and
> those that do not belong to this table.
>
> https://github.com/tarantool/tarantool/issues/4188
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4188-remove-additonal-generated-ids
>
> Changes in v2:
> 1) Patch was divided into 3 new patches.
>
> Changes in v3:
> 1) Removed tests in refactoring patch "sql: remove unnecessary
> AUTOINCREMENT ID generation". They shows nothing.
> 2) Changed the way to check that INSERT executed by trigger.
> 3) Fixed a bug with the display of generated AUTOINCREMENT
> identifiers, even if INSERT failed in the case of INSERT OR
> IGNORE.
>
> Changes in v4:
> 1) Changed the solution for the issue. Now it works without new
> opcode. However, new argument was added to OP_IdxInsert.
> 2) Now the patch in which VDBE does not take into account failed
> inserts becomes practically useless. It has been removed. However,
> a new patch was added that corrects row_count in the specified
> case.
>
> Mergen Imeev (4):
> sql: remove unnecessary AUTOINCREMENT ID generation
> sql: skip autoinc IDs generated inside SQL trigger
> sql: remove VDBE from TXN
> sql: do not increase row-count if INSERT or REPLACE failed
I've checked the patch set into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-07-24 13:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 9:54 [tarantool-patches] " imeevma
2019-07-17 9:54 ` [tarantool-patches] [PATCH v4 1/4] sql: remove unnecessary AUTOINCREMENT ID generation imeevma
2019-07-17 9:54 ` [tarantool-patches] [PATCH v4 2/4] sql: skip autoinc IDs generated inside SQL trigger imeevma
2019-07-17 16:58 ` [tarantool-patches] " n.pettik
2019-07-19 9:33 ` Mergen Imeev
2019-07-17 9:54 ` [tarantool-patches] [PATCH v4 3/4] sql: remove VDBE from TXN imeevma
2019-07-17 9:54 ` [tarantool-patches] [PATCH v4 4/4] sql: do not increase row-count if INSERT or REPLACE failed imeevma
2019-07-17 16:57 ` [tarantool-patches] " n.pettik
2019-07-17 18:08 ` [tarantool-patches] " Мерген Имеев
2019-07-19 9:36 ` Mergen Imeev
2019-07-22 10:48 ` n.pettik
2019-07-22 11:26 ` Mergen Imeev
2019-07-24 13:55 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724135553.zdk66lf2ohbpokd7@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v4 0/4] sql: do not show IDs generated by trigger' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox