From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: "Георгий Кириченко" <georgy@tarantool.org>
Cc: tarantool-patches@freelists.org, kostja@tarantool.org
Subject: Re: [tarantool-patches] [PATCH] txn: don't unref stmt tuples before rollback triggers are run
Date: Wed, 24 Jul 2019 15:55:18 +0300 [thread overview]
Message-ID: <20190724125518.GD11394@esperanza> (raw)
In-Reply-To: <6520487.SKVt4zzWEJ@home.lan>
On Wed, Jul 24, 2019 at 03:30:47PM +0300, Георгий Кириченко wrote:
> Could we consider the possibility to assign triggers on a statement itself?
> In this case you shouldn't implement all that machinery with savepoints.
FYI I scrapped this patch, as I wrote in reply to this email:
https://www.freelists.org/post/tarantool-patches/PATCH-txn-dont-unref-stmt-tuples-before-rollback-triggers-are-run,1
Instead I made savepoints support commit/rollback triggers:
https://www.freelists.org/post/tarantool-patches/PATCH-04-Support-savepoints-in-DDL-transactions
Regarding assigning commit/rollback triggers to individual statements.
Although this would indeed work, I prefer not to do that, because it's
somewhat expensive from the memory usage pov. Besides splitting
commit/rollback trigger lists like that would complicate the code
involving the triggers (running, setting/clearing triggers from Lua).
prev parent reply other threads:[~2019-07-24 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 15:45 Vladimir Davydov
2019-07-19 17:40 ` Vladimir Davydov
2019-07-19 19:28 ` [tarantool-patches] " Vladislav Shpilevoy
2019-07-19 19:36 ` Vladislav Shpilevoy
2019-07-24 12:30 ` [tarantool-patches] " Георгий Кириченко
2019-07-24 12:55 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724125518.GD11394@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=georgy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] txn: don'\''t unref stmt tuples before rollback triggers are run' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox