From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2 2/2] say: take getaddrinfo() errors into account
Date: Tue, 23 Jul 2019 17:52:49 +0300 [thread overview]
Message-ID: <20190723145249.5xwc2td6omphwwzw@tkn_work_nb> (raw)
In-Reply-To: <3603f7507651b37ddd549a8c247709cc7ff43f44.1561469272.git.roman.habibov@tarantool.org>
> @@ -594,6 +594,7 @@ log_syslog_init(struct log *log, const char *init_str)
> log->fd = log_syslog_connect(log);
> if (log->fd < 0) {
> /* syslog indent is freed in atexit(). */
> + diag_log();
1. It is need to be properly commented: we need to log a diagnostics
here until stacked diagnostics will be implemented (#1148).
2. syslog_connect_unix() does not set a diag, diag_log() will lead to an
assertion fail.
3. I would mention this change in the commit message, because it is not
part of the problem with Mac OS you described in it.
next prev parent reply other threads:[~2019-07-23 14:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 13:38 [tarantool-patches] [PATCH v2 0/2] " Roman Khabibov
2019-06-25 13:38 ` [tarantool-patches] [PATCH v2 2/2] say: " Roman Khabibov
2019-07-23 14:52 ` Alexander Turenko [this message]
2019-08-05 13:32 ` [tarantool-patches] " Roman Khabibov
2019-08-28 21:34 ` Alexander Turenko
2019-08-29 0:51 ` Alexander Turenko
[not found] ` <8E98F721-601F-436D-8F0A-5E399D8F7CAB@tarantool.org>
2019-09-06 13:44 ` Alexander Turenko
2019-09-10 12:52 ` Roman Khabibov
2019-11-01 15:19 ` [Tarantool-patches] " Alexander Turenko
2019-11-21 17:28 ` [Tarantool-patches] [tarantool-patches] " Roman Khabibov
2019-12-08 19:48 ` Alexander Turenko
2019-12-10 16:25 ` Roman Khabibov
2019-12-18 15:01 ` Alexander Turenko
2019-12-21 17:50 ` Roman Khabibov
2019-12-23 12:56 ` Alexander Turenko
2019-12-23 13:38 ` Alexander Turenko
2019-12-26 17:29 ` Roman Khabibov
2019-12-26 21:05 ` Alexander Turenko
2019-12-27 13:01 ` Roman Khabibov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723145249.5xwc2td6omphwwzw@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 2/2] say: take getaddrinfo() errors into account' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox