From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Sergey Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] build: enable bundled libyaml for all systems.
Date: Tue, 23 Jul 2019 12:40:16 +0300 [thread overview]
Message-ID: <20190723094016.jzswrwj2zrqheedv@tkn_work_nb> (raw)
In-Reply-To: <1563832103.596220876@f281.i.mail.ru>
> I addressed this issue in a patch to tarantool/libyaml. Please check it out.
> This patch remains intact.
Okay. I don't have objections, but one comment.
> >> - set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w")
> >> + set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w -std=c99")
Maybe it worth to declare a loop variable outside a loop initialization
statement in libyaml (and update the upstream PR)? I mean that if all
libyaml code follow C89, then we maybe should do it too in our changes.
What do you think?
next prev parent reply other threads:[~2019-07-23 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 13:25 [tarantool-patches] " Serge Petrenko
2019-07-22 7:09 ` [tarantool-patches] " Alexander Turenko
2019-07-22 21:48 ` [tarantool-patches] Re[2]: " Sergey Petrenko
2019-07-23 9:40 ` Alexander Turenko [this message]
2019-07-23 18:25 ` [tarantool-patches] Re: [tarantool-patches] " Sergey Petrenko
2019-07-24 8:03 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723094016.jzswrwj2zrqheedv@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] build: enable bundled libyaml for all systems.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox