From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL
Date: Sat, 20 Jul 2019 10:42:10 +0300 [thread overview]
Message-ID: <20190720074210.GA27751@atlas> (raw)
In-Reply-To: <5863bb4286a3e45b3521420273d89347bd331a92.1563576462.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/07/20 01:52]:
> index 000000000..8f7f91151
> --- /dev/null
> +++ b/test/sql/ddl.result
> @@ -0,0 +1,356 @@
> +-- test-run result file version 2
> +test_run = require('test_run').new()
> + | ---
> + | ...
> +engine = test_run:get_cfg('engine')
> + | ---
Just curious why did you choose Lua test format and not SQL?
Now that SQL format is in place my personal preference would be is
that it is used for SQL tests whenever possible, to improve
readability (SQL syntax highlighting, autocompletion).
What do you miss in SQL tests format?
I personally only miss anonymous sql/psm blocks and loops.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-20 7:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 22:49 [tarantool-patches] [PATCH 0/2] SQL TXN DDL Vladislav Shpilevoy
2019-07-19 22:49 ` [tarantool-patches] [PATCH 1/2] alter: do not access space in drop ck commit trigger Vladislav Shpilevoy
2019-07-19 22:49 ` [tarantool-patches] [PATCH 2/2] sql: transactional DDL Vladislav Shpilevoy
2019-07-20 7:42 ` Konstantin Osipov [this message]
2019-07-20 14:02 ` [tarantool-patches] " Vladislav Shpilevoy
2019-07-20 15:16 ` Konstantin Osipov
2019-07-22 13:59 ` n.pettik
2019-07-22 21:35 ` Vladislav Shpilevoy
2019-07-24 13:23 ` n.pettik
2019-07-24 20:58 ` Vladislav Shpilevoy
2019-07-25 12:04 ` n.pettik
2019-07-31 13:19 ` [tarantool-patches] Re: [PATCH 0/2] SQL TXN DDL Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720074210.GA27751@atlas \
--to=kostja@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox