Re: [tarantool-patches] Re: [PATCH] Extend range of printable unicode characters

[Kirill Yukhin <kyukhin@tarantool.org>]

On 18 Jul 12:49, Konstantin Osipov wrote:
> * Kirill Yukhin <kyukhin@tarantool.org> [19/07/18 09:16]:
> > Hello,
> > 
> > On 16 Jul 16:43, Serge Petrenko wrote:
> > > Before the patch IS_PRINTABLE macros was used
> > > to determine if given character is printable or not.
> > > This macros did not take into account characters
> > > encoded with 4 bytes.
> > > After the patch IS_PRINTABLE is replaced with new
> > > corresponding function. Now the range of printable
> > > characters is: (libyaml old range) U (icu range). This
> > > new range include characters encoded with 4 bytes.
> > > 
> > > Related to tarantool/tarantool#4090
> > > ---
> > > https://github.com/tarantool/libyaml/tree/tarantool-gh-4090-fix
> > > https://github.com/tarantool/tarantool/issues/4090
> > 
> > New parsers are out of scope 2.2 release series, so I've checked
> > your patch into master.
> > 
> > Serge, please don't forget to upstream the patch.
> 
> Well, how does this ticket meet 2.2 release criteria? It's not a
> big deal, but why did you choose to not push the bug out of the
> release instead?

Because printing binary garbage instead of string value looks like
a bug to me.

> -- 
> Konstantin Osipov, Moscow, Russia
> 
--
Regards, Kirill Yukhin