From: Konstantin Osipov <kostja@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org, vdavydov.dev@gmail.com
Subject: Re: [PATCH v3 1/4] box: introduce key_def->is_multikey flag
Date: Wed, 17 Jul 2019 17:34:54 +0300 [thread overview]
Message-ID: <20190717143454.GD16650@atlas> (raw)
In-Reply-To: <90d806637a4a9ccb48285beff02b3400d7058f07.1563326037.git.kshcherbatov@tarantool.org>
* Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/07/17 09:39]:
> Previously only key definitions that have JSON paths were able
> to define multikey index. We used to check multikey_path != NULL
> test to determine whether given key definition is multikey.
> In further patches with functional indexes this rule becomes
> outdated. Functional index extracted key definition may be
> multikey, but has no JSON paths.
> So an explicit is_multikey flag was introduced.
The patch is lgtm, but shouldn't you also rename multikey_path to
json_path?
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-17 14:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 1:20 [PATCH v3 0/4] box: functional indexes Kirill Shcherbatov
2019-07-17 1:20 ` [PATCH v3 1/4] box: introduce key_def->is_multikey flag Kirill Shcherbatov
2019-07-17 14:34 ` Konstantin Osipov [this message]
2019-07-18 11:20 ` [tarantool-patches] " Kirill Yukhin
2019-07-17 1:20 ` [PATCH v3 2/4] box: refactor key_validate_parts to return key_end Kirill Shcherbatov
2019-07-18 9:41 ` Konstantin Osipov
2019-07-18 11:21 ` [tarantool-patches] " Kirill Yukhin
2019-07-17 1:20 ` [PATCH v3 3/4] box: introduce tuple_extra infrastructure Kirill Shcherbatov
2019-07-18 9:47 ` Konstantin Osipov
2019-07-17 1:20 ` [PATCH v3 4/4] box: introduce functional indexes in memtx Kirill Shcherbatov
2019-07-18 9:50 ` [tarantool-patches] " Konstantin Osipov
2019-07-18 9:54 ` Konstantin Osipov
2019-07-18 9:55 ` Konstantin Osipov
2019-07-18 10:02 ` Konstantin Osipov
2019-07-22 14:45 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717143454.GD16650@atlas \
--to=kostja@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v3 1/4] box: introduce key_def->is_multikey flag' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox