From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, avtikhon@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v1 1/1] box: do not check state in case of reconnect
Date: Fri, 12 Jul 2019 12:08:14 +0300 [thread overview]
Message-ID: <20190712090814.p3uwjvlhgkdwzzb7@tarantool.org> (raw)
In-Reply-To: <03b9fb9b57353762ee6b9c8fb12fc3dd4c177eb7.1562854125.git.imeevma@gmail.com>
Hello,
On 11 Jul 17:12, imeevma@tarantool.org wrote:
> Test box/net.box.test.lua checks state of the connection in case
> of an error. It should be 'error_reconnect'. But, in cases where
> testing was performed on a slow computer or in the case of a very
> large load, it is possible that the connection status may change
> from the 'error_reconnect' state to another state. This led to the
> failure of the test. Since this check is not the main purpose of
> the test, it is better to simply delete the check.
>
> Closes #4335
> ---
> https://github.com/tarantool/tarantool/issues/4335
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4335-reconnect-state-error
I've checked the patch into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-07-12 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:12 [tarantool-patches] " imeevma
2019-07-11 21:35 ` [tarantool-patches] " Vladislav Shpilevoy
2019-07-12 9:08 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712090814.p3uwjvlhgkdwzzb7@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] box: do not check state in case of reconnect' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox