Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@freelists.org>
Cc: Konstantin Osipov <kostja@tarantool.org>,
	Alexander Turenko <alexander.turenko@tarantool.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [PATCH] box/memtx: Skip tuple memory from coredump by default
Date: Thu, 11 Jul 2019 20:40:50 +0300	[thread overview]
Message-ID: <20190711174050.18880-1-gorcunov@gmail.com> (raw)

Quoting feature request

 | Tarantool is Database and Application Server in one box.
 |
 | Appserver development process contains a lot of
 | lua/luajit-ffi/lua-c-extension code.
 |
 | Coredump is very useful in case when some part of appserver crashed.
 | If the reason is input - data from database is not necessary. If the reason
 | is output - data from database is already in snap/xlog files.
 |
 | Therefore consider core dumps without data enabled by default.

For info: the strip_core feature has been introduced in
549140b390f2db3a29dbba2d44170d215f4c7700

Closes #4337
---
 src/box/lua/load_cfg.lua        | 2 +-
 test/app-tap/init_script.result | 2 +-
 test/box/admin.result           | 2 +-
 test/box/cfg.result             | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/box/lua/load_cfg.lua b/src/box/lua/load_cfg.lua
index d1be0f391..83e99e854 100644
--- a/src/box/lua/load_cfg.lua
+++ b/src/box/lua/load_cfg.lua
@@ -25,7 +25,7 @@ end
 local default_cfg = {
     listen              = nil,
     memtx_memory        = 256 * 1024 *1024,
-    strip_core          = false,
+    strip_core          = true,
     memtx_min_tuple_size = 16,
     memtx_max_tuple_size = 1024 * 1024,
     slab_alloc_factor   = 1.05,
diff --git a/test/app-tap/init_script.result b/test/app-tap/init_script.result
index 16ae8a9c6..6a296d9f6 100644
--- a/test/app-tap/init_script.result
+++ b/test/app-tap/init_script.result
@@ -32,7 +32,7 @@ box.cfg
 27	replication_timeout:1
 28	rows_per_wal:500000
 29	slab_alloc_factor:1.05
-30	strip_core:false
+30	strip_core:true
 31	too_long_threshold:0.5
 32	vinyl_bloom_fpr:0.05
 33	vinyl_cache:134217728
diff --git a/test/box/admin.result b/test/box/admin.result
index bbebbd224..906e01e8d 100644
--- a/test/box/admin.result
+++ b/test/box/admin.result
@@ -85,7 +85,7 @@ cfg_filter(box.cfg)
   - - slab_alloc_factor
     - 1.05
   - - strip_core
-    - false
+    - true
   - - too_long_threshold
     - 0.5
   - - vinyl_bloom_fpr
diff --git a/test/box/cfg.result b/test/box/cfg.result
index 81f4afac8..d85ec634c 100644
--- a/test/box/cfg.result
+++ b/test/box/cfg.result
@@ -73,7 +73,7 @@ cfg_filter(box.cfg)
   - - slab_alloc_factor
     - 1.05
   - - strip_core
-    - false
+    - true
   - - too_long_threshold
     - 0.5
   - - vinyl_bloom_fpr
@@ -174,7 +174,7 @@ cfg_filter(box.cfg)
   - - slab_alloc_factor
     - 1.05
   - - strip_core
-    - false
+    - true
   - - too_long_threshold
     - 0.5
   - - vinyl_bloom_fpr
-- 
2.20.1

             reply	other threads:[~2019-07-11 17:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 17:40 Cyrill Gorcunov [this message]
2019-07-11 22:31 ` [PATCH v2] " Cyrill Gorcunov
2019-07-12  8:52 ` [tarantool-patches] [PATCH] " Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190711174050.18880-1-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=alexander.turenko@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH] box/memtx: Skip tuple memory from coredump by default' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox