From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] sql: boolean introduction follow-ups
Date: Thu, 11 Jul 2019 12:13:42 +0300 [thread overview]
Message-ID: <20190711091342.iigjzzc7vqpdvdzw@tarantool.org> (raw)
In-Reply-To: <cover.1561459671.git.korablev@tarantool.org>
Hello,
On 25 Jun 14:42, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/boolean-follow-ups
>
> First patch gets rid of redundant conversion of results from booleans
> to numeric values 0 and 1 in testing framework (sqltester).
>
> Second one fixes obvious bug during comparison of booleans with values
> of other types.
>
> Nikita Pettik (2):
> sqltester: don't convert booleans to 0/1 numerics
> sql: fix antisymmetric boolean comparison in VDBE
I've checked your patches into master.
--
Regrads, Kirill Yukhin
prev parent reply other threads:[~2019-07-11 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 11:42 [tarantool-patches] " Nikita Pettik
2019-06-25 11:42 ` [tarantool-patches] [PATCH 1/2] sqltester: don't convert booleans to 0/1 numerics Nikita Pettik
2019-06-25 11:42 ` [tarantool-patches] [PATCH 2/2] sql: fix antisymmetric boolean comparison in VDBE Nikita Pettik
2019-06-27 19:02 ` [tarantool-patches] Re: [PATCH 0/2] sql: boolean introduction follow-ups Vladislav Shpilevoy
2019-07-11 9:13 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711091342.iigjzzc7vqpdvdzw@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 0/2] sql: boolean introduction follow-ups' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox