From: Konstantin Osipov <kostja@tarantool.org> To: Kirill Shcherbatov <kshcherbatov@tarantool.org> Cc: tarantool-patches@freelists.org, korablev@tarantool.org Subject: [tarantool-patches] Re: [PATCH v2 03/12] sql: put analyze helpers to FuncDef cache Date: Wed, 10 Jul 2019 22:04:37 +0300 [thread overview] Message-ID: <20190710190437.GE5619@atlas> (raw) In-Reply-To: <df60e4bc84f0f7f8c297595618089c9c800b3274.1562756438.git.kshcherbatov@tarantool.org> * Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/07/10 14:02]: > Previously analyze functions refer to statically defined > service FuncDef context. We need to change this approach due we > going to rework the builtins functions machinery in following > patches. lgtm, but please ask Nikita to give another review. > Needed for #4113, #2200, #2233 -- Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-10 19:04 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-10 11:00 [tarantool-patches] [PATCH v2 00/12] sql: uniform SQL and Lua functions subsystem Kirill Shcherbatov 2019-07-10 11:00 ` [tarantool-patches] [PATCH v2 01/12] sql: get rid of SOUNDEX, MATCH Kirill Shcherbatov 2019-07-10 18:45 ` [tarantool-patches] " Konstantin Osipov 2019-07-12 8:44 ` Kirill Yukhin 2019-07-10 11:00 ` [tarantool-patches] [PATCH v2 10/12] sql: refactor builtins signatures with port Kirill Shcherbatov 2019-07-10 18:47 ` [tarantool-patches] " Konstantin Osipov 2019-07-11 7:33 ` Kirill Shcherbatov 2019-07-10 11:00 ` [tarantool-patches] [PATCH v2 11/12] box: use own vtab per each function object Kirill Shcherbatov 2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 12/12] sql: use schema's func hash instead of FuncDef hash Kirill Shcherbatov 2019-07-10 20:22 ` [tarantool-patches] " Konstantin Osipov 2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 02/12] sql: get rid of LIKELY, UNLIKELY and LIKEHOOD Kirill Shcherbatov 2019-07-10 19:02 ` [tarantool-patches] " Konstantin Osipov 2019-07-11 7:38 ` Kirill Shcherbatov 2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 03/12] sql: put analyze helpers to FuncDef cache Kirill Shcherbatov 2019-07-10 19:04 ` Konstantin Osipov [this message] 2019-07-12 8:47 ` [tarantool-patches] " Kirill Yukhin 2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 04/12] sql: rework LIKE case-insensitive mode Kirill Shcherbatov 2019-07-10 19:09 ` [tarantool-patches] " Konstantin Osipov 2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 05/12] sql: replace bool is_derived_coll marker with flag Kirill Shcherbatov 2019-07-10 19:10 ` [tarantool-patches] " Konstantin Osipov 2019-07-12 8:48 ` Kirill Yukhin 2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 06/12] sql: remove SQL_PreferBuiltin flag Kirill Shcherbatov 2019-07-10 19:11 ` [tarantool-patches] " Konstantin Osipov 2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 07/12] sql: move LIKE UConverter object to collation library Kirill Shcherbatov 2019-07-12 8:49 ` [tarantool-patches] " Kirill Yukhin 2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 08/12] sql: rfc for SQL and Lua functions Kirill Shcherbatov 2019-07-10 19:17 ` [tarantool-patches] " Konstantin Osipov 2019-07-10 19:18 ` Konstantin Osipov 2019-07-11 7:40 ` Kirill Shcherbatov 2019-07-11 13:59 ` Kirill Yukhin 2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 09/12] box: introduce Lua persistent functions Kirill Shcherbatov 2019-07-10 19:26 ` [tarantool-patches] " Konstantin Osipov 2019-07-12 21:49 ` Konstantin Osipov 2019-07-13 13:55 ` Kirill Yukhin 2019-07-13 14:17 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190710190437.GE5619@atlas \ --to=kostja@tarantool.org \ --cc=korablev@tarantool.org \ --cc=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v2 03/12] sql: put analyze helpers to FuncDef cache' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox