Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/2] swim: pool IO tasks
Date: Wed, 10 Jul 2019 01:24:44 +0300	[thread overview]
Message-ID: <20190709222444.GA19365@atlas> (raw)
In-Reply-To: <743246c0-7780-2c1e-06d7-1c86d17140e6@tarantool.org>

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/07/09 23:48]:
> The patchset is pushed to the master.
> 
> On 09/07/2019 01:08, Konstantin Osipov wrote:
> > * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/07/09 01:13]:
> >> Yes, you misunderstood something. This is the whole point of this
> >> commit - make number of tasks not depending on a number of members.
> >> On the master branch now the number of tasks per SWIM is linear of
> >> cluster size - it is terrible. Both 1 and 2 tasks per member are
> >> linear.
> >>
> >> But network load per one instance does not depend on number of members,
> >> so we can make number of tasks independent from cluster size. I am trying
> >> to reuse a small set of tasks for all members of one instance. Just
> >> imagine - a SWIM instance knows about 500 members, and manages to work
> >> with them using just 2-10 messages at once.
> > 
> > ok, then a mempool is an overkill for sure.

the comment about static global variables being unsafe still
remains.

Please assert or make the library thread-safe.

-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2019-07-09 22:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 22:40 [tarantool-patches] [PATCH 0/2] SWIM micro optimizations Vladislav Shpilevoy
2019-07-05 22:40 ` [tarantool-patches] [PATCH 1/2] swim: pool IO tasks Vladislav Shpilevoy
2019-07-05 23:01   ` [tarantool-patches] " Konstantin Osipov
2019-07-06 21:00     ` Vladislav Shpilevoy
2019-07-08  8:25       ` Konstantin Osipov
2019-07-08 18:31         ` Vladislav Shpilevoy
2019-07-08 21:54           ` Konstantin Osipov
2019-07-08 22:13             ` Vladislav Shpilevoy
2019-07-08 23:08               ` Konstantin Osipov
2019-07-09 19:43                 ` Vladislav Shpilevoy
2019-07-09 22:24                   ` Konstantin Osipov [this message]
2019-07-05 22:40 ` [tarantool-patches] [PATCH 2/2] swim: optimize struct swim_task layout Vladislav Shpilevoy
2019-07-05 23:02   ` [tarantool-patches] " Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190709222444.GA19365@atlas \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH 1/2] swim: pool IO tasks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox