Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Олег <olegrok@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v2] fio: introduce utime function
Date: Tue, 9 Jul 2019 11:55:08 +0300	[thread overview]
Message-ID: <20190709085508.vkpe5kgrqfspmk5h@esperanza> (raw)
In-Reply-To: <0539c600-d652-fa15-3c3f-7e1cd6fb0dee@tarantool.org>

On Mon, Jul 08, 2019 at 06:52:24PM +0300, Олег wrote:
> 
> Thanks! My bad. I really missed it.
> 
> Please apply following diff to my patch.
> 
> diff --git a/src/lua/fio.c b/src/lua/fio.c
> index 55fa66762..48e2f8eb3 100644
> --- a/src/lua/fio.c
> +++ b/src/lua/fio.c
> @@ -709,7 +709,7 @@ lbox_fio_utime(struct lua_State *L)
>      const char *pathname = lua_tostring(L, 1);
>      double atime = lua_tonumber(L, 2);
>      double mtime = lua_tonumber(L, 3);
> -    return lbox_fio_pushbool(L, coio_utime(pathname, atime, mtime) == 0);
> +    return lbox_fio_pushbool(L, coio_utime(pathname, mtime, atime) == 0);
>  }

So, now we have:

  eio_utime(path, atime, mtime)
  coio_utime(path, mtime, atime)
  fio.utime(path, atime, mtime)

I think that for the sake of consistency coio_utime should take atime as
the second argument and mtime as the third.

Please fix and send v3 in a separate email.

      reply	other threads:[~2019-07-09  8:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 19:07 Oleg Babin
2019-07-08 14:51 ` Vladimir Davydov
2019-07-08 15:52   ` [tarantool-patches] " Олег
2019-07-09  8:55     ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190709085508.vkpe5kgrqfspmk5h@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=olegrok@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] Re: [PATCH v2] fio: introduce utime function' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox