From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 4/5] memtx: fix txn_on_yield for DDL transactions
Date: Tue, 9 Jul 2019 10:51:36 +0300 [thread overview]
Message-ID: <20190709075135.g3yakycaitout4wp@esperanza> (raw)
In-Reply-To: <20190708215750.GD7873@atlas>
On Tue, Jul 09, 2019 at 12:57:50AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/08 22:14]:
> > > another way to do it is to clear fiber->txn key whenever
> > > check_format /build_index functions yield. Basically these
> > > functions run in the background, in a transaction that is
> > > temporarily detached from the main fiber so should not pollute the
> > > caller fiber key.
> >
> > I don't get it. Need to discuss f2f.
>
> I don't get why you need to call this from vinyl.
>
> If both engines use the api, it should be txn_* api of course. but
> I don't get why both engines need to use it, vinyl doesn't set
> yield triggers to my knowledge.
DDL is a memtx operation, but actual index creation is done in
vinyl_space_build_index.
next prev parent reply other threads:[~2019-07-09 7:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 20:25 [PATCH 0/5] Transactional DDL Vladimir Davydov
2019-07-05 20:25 ` [PATCH 1/5] vinyl: don't sync WAL on space alter if not necessary Vladimir Davydov
2019-07-08 9:29 ` Konstantin Osipov
2019-07-08 9:50 ` Vladimir Davydov
2019-07-08 15:01 ` Vladimir Davydov
2019-07-05 20:25 ` [PATCH 2/5] txn: run on_rollback triggers on txn_abort Vladimir Davydov
2019-07-08 9:32 ` Konstantin Osipov
2019-07-08 9:57 ` Vladimir Davydov
2019-07-08 12:14 ` Konstantin Osipov
2019-07-08 16:37 ` Vladimir Davydov
2019-07-08 21:56 ` Konstantin Osipov
2019-07-09 8:49 ` Vladimir Davydov
2019-07-05 20:25 ` [PATCH 3/5] txn: fix execution order of commit triggers Vladimir Davydov
2019-07-08 12:17 ` Konstantin Osipov
2019-07-08 15:01 ` Vladimir Davydov
2019-07-05 20:25 ` [PATCH 4/5] memtx: fix txn_on_yield for DDL transactions Vladimir Davydov
2019-07-08 12:22 ` Konstantin Osipov
2019-07-08 16:41 ` Vladimir Davydov
2019-07-08 16:58 ` Vladimir Davydov
2019-07-09 10:12 ` Vladimir Davydov
2019-07-08 21:57 ` Konstantin Osipov
2019-07-09 7:51 ` Vladimir Davydov [this message]
2019-07-05 20:25 ` [PATCH 5/5] Allow to execute non-yielding DDL statements in transactions Vladimir Davydov
2019-07-05 22:56 ` Konstantin Osipov
2019-07-08 8:09 ` Vladimir Davydov
2019-07-08 8:21 ` Konstantin Osipov
2019-07-08 8:43 ` Vladimir Davydov
2019-07-08 9:25 ` Konstantin Osipov
2019-07-08 16:46 ` Vladimir Davydov
2019-07-08 21:59 ` Konstantin Osipov
2019-07-08 12:26 ` Konstantin Osipov
2019-07-08 16:51 ` Vladimir Davydov
2019-07-08 22:02 ` Konstantin Osipov
2019-07-09 8:11 ` Vladimir Davydov
2019-07-09 11:03 ` Vladimir Davydov
2019-07-08 12:31 ` Konstantin Osipov
2019-07-08 17:00 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709075135.g3yakycaitout4wp@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH 4/5] memtx: fix txn_on_yield for DDL transactions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox