[tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections

[tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections

[Alexander Turenko]

Alexander, I have already answered for this patch. Please, read the
previous review:

https://www.freelists.org/post/tarantool-patches/PATCH-v1-test-use-unix-sockets-for-iproto-connections,3

WBR, Alexander Turenko.

On Mon, Jul 08, 2019 at 03:03:49PM +0300, Alexander V. Tikhonov wrote:
> Use unix sockets for iproto connections in sql-tap suite.
> Enabled use_unix_sockets_iproto option to use unix sockets
> iproto provides the new way to handle the problem with
> 'Address already in use' error. It lets test-run appoint
> unix sockets for LISTEN environment variable values.
> Check the previous commit for the other suites:
> 
> 60f84cbfca24e3a91cea067c923e006b44ee589f ('test: use unix sockets for iproto connections')
> 
> Closes #4008
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/avtikhon/use_unix_sockets_iproto_sql_tap
> Issue: https://github.com/tarantool/tarantool/issues/4008
> 
>  test/sql-tap/suite.ini | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
> index 2dfae4442..cba1d1fc6 100644
> --- a/test/sql-tap/suite.ini
> +++ b/test/sql-tap/suite.ini
> @@ -24,6 +24,8 @@ disabled = selectA.test.lua ;
>  
>  lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
>  is_parallel = True
> +use_unix_sockets = True
> +use_unix_sockets_iproto = True
>  release_disabled = debug_mode_only.test.lua
>  long_run = gh-3332-tuple-format-leak.test.lua, gh-3083-ephemeral-unref-tuples.test.lua
>  config = engine.cfg
> -- 
> 2.17.1
> 

[tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections

[Alexander Turenko]

Sorry, my bad. I forgot that I had implemented it only for core =
tarantool test suites.

So first implement it in test-run for core = app suites, please.

WBR, Alexander Turenko.

> test: use unix sockets for iproto connections

It is not good to have two different commits with the same commit
message header (say, you use a header to search a commit that is
cherry-picked from another one). I think it worth to mention that the
commit is about sql-tap if the 50 symbols limit allows.

> Use unix sockets for iproto connections in sql-tap suite.
> Enabled use_unix_sockets_iproto option to use unix sockets
> iproto provides the new way to handle the problem with

'Use unix sockets iproto' sound as a bag of words.

> 'Address already in use' error. It lets test-run appoint
> unix sockets for LISTEN environment variable values.
> Check the previous commit for the other suites:
> 
> 60f84cbfca24e3a91cea067c923e006b44ee589f ('test: use unix sockets for iproto connections')
> 
> Closes #4008

The issue is already closed, it is better to say 'Follows up #4008'.

> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/use_unix_sockets_iproto_sql_tap
> Issue: https://github.com/tarantool/tarantool/issues/4008
> 
>  test/sql-tap/suite.ini | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
> index 2dfae4442..cba1d1fc6 100644
> --- a/test/sql-tap/suite.ini
> +++ b/test/sql-tap/suite.ini
> @@ -24,6 +24,8 @@ disabled = selectA.test.lua ;
>  
>  lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
>  is_parallel = True
> +use_unix_sockets = True

As far as I see this option does not affect anything for core = app test
suites. It is about ADMIN env variable, it is not used in app tests.

Aside of that this is not mentioned in the commit message.

> +use_unix_sockets_iproto = True
>  release_disabled = debug_mode_only.test.lua
>  long_run = gh-3332-tuple-format-leak.test.lua, gh-3083-ephemeral-unref-tuples.test.lua
>  config = engine.cfg
> -- 
> 2.17.1
> 

Sasha, please check that the patch really works next time. It is in your
responsibility.

[tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections

[Alexander Turenko]

On Fri, Jun 07, 2019 at 08:20:42AM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 07 Jun 07:21, Alexander V. Tikhonov wrote:
> > From: avtikhon <avtikhon@tarantool.org>
> > 
> > Enabled use_unix_sockets_iproto option to use unix sockets
> > iproto provides the new way to handle the problem with
> > 'Address already in use' error. It lets test-run appoint
> > unix sockets for LISTEN environment variable values.
> > 
> > Before this change the TcpPortDispatcher was used to
> > eliminate the race condition when two workers trying to use
> > the same port: the idea was that each worker used its own
> > ports range. Really these ports could race with client ports
> > (from, say, net.box or replication), which typically didn't
> > use bind() and so bound to a random available port (despite
> > any dispatched ranges) and could produce 'Address already in
> > use' error.
> > 
> > Closes: #4008
> > ---
> > 
> > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4008-test-in-parallel-iproto
> > Issue: https://github.com/tarantool/tarantool/issues/4008
> 
> I've checked your patch into master and 2.1 branch.

I think it is needed for 1.10 too.

[tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections

[Kirill Yukhin]

Hello,

On 07 Jun 07:21, Alexander V. Tikhonov wrote:
> From: avtikhon <avtikhon@tarantool.org>
> 
> Enabled use_unix_sockets_iproto option to use unix sockets
> iproto provides the new way to handle the problem with
> 'Address already in use' error. It lets test-run appoint
> unix sockets for LISTEN environment variable values.
> 
> Before this change the TcpPortDispatcher was used to
> eliminate the race condition when two workers trying to use
> the same port: the idea was that each worker used its own
> ports range. Really these ports could race with client ports
> (from, say, net.box or replication), which typically didn't
> use bind() and so bound to a random available port (despite
> any dispatched ranges) and could produce 'Address already in
> use' error.
> 
> Closes: #4008
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4008-test-in-parallel-iproto
> Issue: https://github.com/tarantool/tarantool/issues/4008

I've checked your patch into master and 2.1 branch.

--
Regards, Kirill Yukhin