From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections
Date: Tue, 9 Jul 2019 00:45:25 +0300 [thread overview]
Message-ID: <20190708214525.igttjhcdfsyfwp6t@tkn_work_nb> (raw)
In-Reply-To: <8390add718a4ba07836c2143ca3286df8c577ff3.1562587370.git.avtikhon@tarantool.org>
Alexander, I have already answered for this patch. Please, read the
previous review:
https://www.freelists.org/post/tarantool-patches/PATCH-v1-test-use-unix-sockets-for-iproto-connections,3
WBR, Alexander Turenko.
On Mon, Jul 08, 2019 at 03:03:49PM +0300, Alexander V. Tikhonov wrote:
> Use unix sockets for iproto connections in sql-tap suite.
> Enabled use_unix_sockets_iproto option to use unix sockets
> iproto provides the new way to handle the problem with
> 'Address already in use' error. It lets test-run appoint
> unix sockets for LISTEN environment variable values.
> Check the previous commit for the other suites:
>
> 60f84cbfca24e3a91cea067c923e006b44ee589f ('test: use unix sockets for iproto connections')
>
> Closes #4008
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/avtikhon/use_unix_sockets_iproto_sql_tap
> Issue: https://github.com/tarantool/tarantool/issues/4008
>
> test/sql-tap/suite.ini | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
> index 2dfae4442..cba1d1fc6 100644
> --- a/test/sql-tap/suite.ini
> +++ b/test/sql-tap/suite.ini
> @@ -24,6 +24,8 @@ disabled = selectA.test.lua ;
>
> lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
> is_parallel = True
> +use_unix_sockets = True
> +use_unix_sockets_iproto = True
> release_disabled = debug_mode_only.test.lua
> long_run = gh-3332-tuple-format-leak.test.lua, gh-3083-ephemeral-unref-tuples.test.lua
> config = engine.cfg
> --
> 2.17.1
>
next parent reply other threads:[~2019-07-08 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8390add718a4ba07836c2143ca3286df8c577ff3.1562587370.git.avtikhon@tarantool.org>
2019-07-08 21:45 ` Alexander Turenko [this message]
[not found] <8390add718a4ba07836c2143ca3286df8c577ff3.1562316047.git.avtikhon@tarantool.org>
2019-07-05 15:02 ` Alexander Turenko
2019-06-07 4:21 [tarantool-patches] " Alexander V. Tikhonov
2019-06-07 5:20 ` [tarantool-patches] " Kirill Yukhin
2019-06-07 16:12 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708214525.igttjhcdfsyfwp6t@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1] test: use unix sockets for iproto connections' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox