From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] vinyl: fix vy_range_update_compaction_priority hang
Date: Mon, 8 Jul 2019 16:51:40 +0300 [thread overview]
Message-ID: <20190708135140.q7o5qbfvtnvgiuny@esperanza> (raw)
In-Reply-To: <20190708134854.GA15305@atlas>
On Mon, Jul 08, 2019 at 04:48:54PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/08 16:38]:
>
> Please push this asap since there is a customer waiting for fix.
Pushed to master, 2.1, and 1.10.
>
> Please also fix VY_ROUND_UP type safety - let's make it static
> inline instead.
I can't - we do need to pass double as a divident to it, because
run_size_ratio is double.
>
> This needs a test case as a follow up and a proper fix should drop
> all such slices.
That's going to be tricky. I'll look if we can actually do that.
prev parent reply other threads:[~2019-07-08 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 13:36 Vladimir Davydov
2019-07-08 13:48 ` Konstantin Osipov
2019-07-08 13:51 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708135140.q7o5qbfvtnvgiuny@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] vinyl: fix vy_range_update_compaction_priority hang' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox