Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@scylladb.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 5/5] Allow to execute non-yielding DDL statements in transactions
Date: Mon, 8 Jul 2019 11:09:34 +0300	[thread overview]
Message-ID: <20190708080934.hp3zgk6ppw5mu2ww@esperanza> (raw)
In-Reply-To: <20190705225635.GB30966@atlas>

On Sat, Jul 06, 2019 at 01:56:35AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/05 23:27]:
> 
> Please work on a test case which not only ensures the statements
> are allowed, but also produce desired results - as well as leave
> no traces/partial effects on rollback.

As a matter of fact, this simple test does check that rollback doesn't
leave any traces - if it did, an attempt to commit the same statements
would fail:

  box.begin() create() box.rollback() -- suppose it leaved some traces
  box.begin() create() box.commit() -- then this would fail

It also checks that the DDL operations produce the desired results,
otherwise an attempt to drop created objects would fail:

  box.begin() create() box.commit() -- suppose it didn't create some objects
  box.begin() drop() box.commit() -- then this would fail

  reply	other threads:[~2019-07-08  8:09 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 20:25 [PATCH 0/5] Transactional DDL Vladimir Davydov
2019-07-05 20:25 ` [PATCH 1/5] vinyl: don't sync WAL on space alter if not necessary Vladimir Davydov
2019-07-08  9:29   ` Konstantin Osipov
2019-07-08  9:50     ` Vladimir Davydov
2019-07-08 15:01   ` Vladimir Davydov
2019-07-05 20:25 ` [PATCH 2/5] txn: run on_rollback triggers on txn_abort Vladimir Davydov
2019-07-08  9:32   ` Konstantin Osipov
2019-07-08  9:57     ` Vladimir Davydov
2019-07-08 12:14       ` Konstantin Osipov
2019-07-08 16:37         ` Vladimir Davydov
2019-07-08 21:56           ` Konstantin Osipov
2019-07-09  8:49             ` Vladimir Davydov
2019-07-05 20:25 ` [PATCH 3/5] txn: fix execution order of commit triggers Vladimir Davydov
2019-07-08 12:17   ` Konstantin Osipov
2019-07-08 15:01   ` Vladimir Davydov
2019-07-05 20:25 ` [PATCH 4/5] memtx: fix txn_on_yield for DDL transactions Vladimir Davydov
2019-07-08 12:22   ` Konstantin Osipov
2019-07-08 16:41     ` Vladimir Davydov
2019-07-08 16:58       ` Vladimir Davydov
2019-07-09 10:12         ` Vladimir Davydov
2019-07-08 21:57       ` Konstantin Osipov
2019-07-09  7:51         ` Vladimir Davydov
2019-07-05 20:25 ` [PATCH 5/5] Allow to execute non-yielding DDL statements in transactions Vladimir Davydov
2019-07-05 22:56   ` Konstantin Osipov
2019-07-08  8:09     ` Vladimir Davydov [this message]
2019-07-08  8:21       ` Konstantin Osipov
2019-07-08  8:43         ` Vladimir Davydov
2019-07-08  9:25           ` Konstantin Osipov
2019-07-08 16:46             ` Vladimir Davydov
2019-07-08 21:59               ` Konstantin Osipov
2019-07-08 12:26   ` Konstantin Osipov
2019-07-08 16:51     ` Vladimir Davydov
2019-07-08 22:02       ` Konstantin Osipov
2019-07-09  8:11         ` Vladimir Davydov
2019-07-09 11:03           ` Vladimir Davydov
2019-07-08 12:31   ` Konstantin Osipov
2019-07-08 17:00     ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708080934.hp3zgk6ppw5mu2ww@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=kostja@scylladb.com \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH 5/5] Allow to execute non-yielding DDL statements in transactions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox