From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tml <tarantool-patches@freelists.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format
Date: Sat, 6 Jul 2019 09:50:02 +0300 [thread overview]
Message-ID: <20190706065002.GB4602@uranus.lan> (raw)
In-Reply-To: <20190705225908.GC30966@atlas>
On Sat, Jul 06, 2019 at 01:59:08AM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [19/07/06 00:13]:
>
> LGTM. @totktonada, please provide a more thorough review.
>
> One question is what happens to the output on client reconnect.
Since it gonna be new session the settings will be reset. I thought
also that we might need to provide some box.cgf option for default
output mode?
> Perhaps we should cache it on the client as well (this is the same
> issue with console language).
Well, seems so, still it is a bit unclear for me where to keep this
cached value.
As to "default lua" for 2.x series we need to think how to tune
up our test engine to setup yaml mode for all tests, since currently
test results are in yaml and we definitely don't wanna update every
test exsiting.
next prev parent reply other threads:[~2019-07-06 6:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 21:09 [tarantool-patches] [RFC v2 0/2] " Cyrill Gorcunov
2019-07-05 21:09 ` [tarantool-patches] [RFC 1/2] third_party/serpent: Add serpent repo Cyrill Gorcunov
2019-07-05 21:09 ` [tarantool-patches] [RFC 2/2] box/lua/console: Add support for lua output format Cyrill Gorcunov
2019-07-05 22:59 ` [tarantool-patches] " Konstantin Osipov
2019-07-05 23:04 ` Konstantin Osipov
2019-07-06 6:50 ` Cyrill Gorcunov [this message]
2019-07-06 16:02 ` Konstantin Osipov
2019-07-06 20:35 ` Cyrill Gorcunov
2019-07-09 3:46 ` Alexander Turenko
2019-07-09 18:06 ` Konstantin Osipov
2019-07-09 3:19 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190706065002.GB4602@uranus.lan \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox