From: Konstantin Osipov <kostja@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format
Date: Sat, 6 Jul 2019 02:04:10 +0300 [thread overview]
Message-ID: <20190705230410.GF30966@atlas> (raw)
In-Reply-To: <20190705225908.GC30966@atlas>
* Konstantin Osipov <kostja@tarantool.org> [19/07/06 01:59]:
> * Cyrill Gorcunov <gorcunov@gmail.com> [19/07/06 00:13]:
>
> LGTM. @totktonada, please provide a more thorough review.
>
> One question is what happens to the output on client reconnect.
> Perhaps we should cache it on the client as well (this is the same
> issue with console language).
This matter is obviously is not a blocker, can be worked on in a
follow up patch.
Last thing, Lua output should be the default in 2.x
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-05 23:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 21:09 [tarantool-patches] [RFC v2 0/2] " Cyrill Gorcunov
2019-07-05 21:09 ` [tarantool-patches] [RFC 1/2] third_party/serpent: Add serpent repo Cyrill Gorcunov
2019-07-05 21:09 ` [tarantool-patches] [RFC 2/2] box/lua/console: Add support for lua output format Cyrill Gorcunov
2019-07-05 22:59 ` [tarantool-patches] " Konstantin Osipov
2019-07-05 23:04 ` Konstantin Osipov [this message]
2019-07-06 6:50 ` Cyrill Gorcunov
2019-07-06 16:02 ` Konstantin Osipov
2019-07-06 20:35 ` Cyrill Gorcunov
2019-07-09 3:46 ` Alexander Turenko
2019-07-09 18:06 ` Konstantin Osipov
2019-07-09 3:19 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705230410.GF30966@atlas \
--to=kostja@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox