From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/2] swim: pool IO tasks
Date: Sat, 6 Jul 2019 02:01:36 +0300 [thread overview]
Message-ID: <20190705230136.GD30966@atlas> (raw)
In-Reply-To: <e4e8fb8c60d5438e3659af4d7896b8fe548e10a0.1562366340.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/07/06 01:39]:
> +
> +/**
> + * All the SWIM instances and their members use the same objects
> + * to send data - tasks. Each task is ~1.5KB, and on one hand it
> + * would be a waste of memory to keep preallocated tasks for each
> + * member. One the other hand it would be too slow to allocate
> + * and delete ~1.5KB on each interaction, ~3KB on each round step.
> + * Here is a pool of free tasks shared among all SWIM instances
> + * to avoid allocations, but do not keep a separate task for each
> + * member.
> + */
> +static struct stailq swim_task_pool;
> +/** Number of pooled tasks. */
> +static int swim_task_pool_size = 0;
These should be thread-local.
Why not use mempool?
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-05 23:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 22:40 [tarantool-patches] [PATCH 0/2] SWIM micro optimizations Vladislav Shpilevoy
2019-07-05 22:40 ` [tarantool-patches] [PATCH 1/2] swim: pool IO tasks Vladislav Shpilevoy
2019-07-05 23:01 ` Konstantin Osipov [this message]
2019-07-06 21:00 ` [tarantool-patches] " Vladislav Shpilevoy
2019-07-08 8:25 ` Konstantin Osipov
2019-07-08 18:31 ` Vladislav Shpilevoy
2019-07-08 21:54 ` Konstantin Osipov
2019-07-08 22:13 ` Vladislav Shpilevoy
2019-07-08 23:08 ` Konstantin Osipov
2019-07-09 19:43 ` Vladislav Shpilevoy
2019-07-09 22:24 ` Konstantin Osipov
2019-07-05 22:40 ` [tarantool-patches] [PATCH 2/2] swim: optimize struct swim_task layout Vladislav Shpilevoy
2019-07-05 23:02 ` [tarantool-patches] " Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705230136.GD30966@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/2] swim: pool IO tasks' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox