From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 5/5] swim: speed-up empty payloads cluster bootstrap
Date: Thu, 4 Jul 2019 11:26:09 +0300 [thread overview]
Message-ID: <20190704082609.GK24820@atlas> (raw)
In-Reply-To: <c9b5b56bb968f251fce37ccf08cc3427aabdcf6d.1562196102.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/07/04 10:15]:
> One another place consuming most of the tests start up time is
> useless dissemination of an empty payload, which can be skipped
> in fact.
>
> Consider a cluster of 300 nodes. Each one of them are
> interconnected manually, and now a test wants to wait for a
> stabilization, when there are no events. On such a cluster it
> happens for ~200 round steps till there are no any single event.
>
> This is not about big packets, or log() TTD. There may be a few
> events, may be more, but when a test wants the cluster to be
> clean, it needs to wait for all the events being done.
>
> This patch abuses the fact, that empty payloads can be compared
> for free, no any single memcmp. If both new and the old payload
> are empty, then nothing to disseminate.
>
> It could help in a real cluster too, if initially there are no
> payloads.
lgtm
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-04 8:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 23:28 [tarantool-patches] [PATCH 0/5] SWIM loglog preparation Vladislav Shpilevoy
2019-07-03 23:28 ` [tarantool-patches] [PATCH 1/5] swim: fix flaky 'indirect pings' test Vladislav Shpilevoy
2019-07-04 8:20 ` [tarantool-patches] " Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 2/5] swim: sadly remove cache Vladislav Shpilevoy
2019-07-04 8:22 ` [tarantool-patches] " Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 3/5] test: redo some swim tests using error injections Vladislav Shpilevoy
2019-07-04 8:23 ` [tarantool-patches] " Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 4/5] swim: speed-up tests Vladislav Shpilevoy
2019-07-04 8:24 ` [tarantool-patches] " Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 5/5] swim: speed-up empty payloads cluster bootstrap Vladislav Shpilevoy
2019-07-04 8:26 ` Konstantin Osipov [this message]
2019-07-05 22:44 ` [tarantool-patches] Re: [PATCH 0/5] SWIM loglog preparation Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704082609.GK24820@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 5/5] swim: speed-up empty payloads cluster bootstrap' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox