From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 2/5] swim: sadly remove cache
Date: Thu, 4 Jul 2019 11:22:05 +0300 [thread overview]
Message-ID: <20190704082205.GH24820@atlas> (raw)
In-Reply-To: <c335d87ed7722859c288004d798a099f4a2844c5.1562196102.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/07/04 10:15]:
> SWIM sends basically the same message during a round. There was
> a microoptimization so as not to reassemble the message on each
> step. Now it is getting harder to support that island of
> perfectionism, because
>
> * Soon all the messages will carry all the sections,
> including indirect messages. Their body is smaller, so it
> is not possible to maintain one cached message without
> reducing its maximal size;
>
> * In big-clusters even without any changes a cached message
> would need to be rebuilt. This is because anti-entropy
> section won't help much unless it is being changed
> frequent enough;
>
> * In big clusters changes happen often enough to invalidate
> the cached message constantly, unless SWIM would had
> maintained what members are included into the cache, and
> which are not. Then change of a member, not included into
> the message, would not affect the cache. But it would
> complicate the code too much.
>
> Part of #4253
lgtm
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-04 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 23:28 [tarantool-patches] [PATCH 0/5] SWIM loglog preparation Vladislav Shpilevoy
2019-07-03 23:28 ` [tarantool-patches] [PATCH 1/5] swim: fix flaky 'indirect pings' test Vladislav Shpilevoy
2019-07-04 8:20 ` [tarantool-patches] " Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 2/5] swim: sadly remove cache Vladislav Shpilevoy
2019-07-04 8:22 ` Konstantin Osipov [this message]
2019-07-03 23:28 ` [tarantool-patches] [PATCH 3/5] test: redo some swim tests using error injections Vladislav Shpilevoy
2019-07-04 8:23 ` [tarantool-patches] " Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 4/5] swim: speed-up tests Vladislav Shpilevoy
2019-07-04 8:24 ` [tarantool-patches] " Konstantin Osipov
2019-07-03 23:28 ` [tarantool-patches] [PATCH 5/5] swim: speed-up empty payloads cluster bootstrap Vladislav Shpilevoy
2019-07-04 8:26 ` [tarantool-patches] " Konstantin Osipov
2019-07-05 22:44 ` [tarantool-patches] Re: [PATCH 0/5] SWIM loglog preparation Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704082205.GH24820@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 2/5] swim: sadly remove cache' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox