From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 4/6] test: make vinyl/replica_rejoin more stable
Date: Wed, 3 Jul 2019 22:23:03 +0300 [thread overview]
Message-ID: <20190703192303.GG17318@atlas> (raw)
In-Reply-To: <62314c2482b5d12671e713ee08f47f266e153610.1561922496.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/01 10:04]:
> The test checks that files left after rebootstrap are removed by the
> garbage collector. It does that by printing file names to the result
> file. This is inherently unstable, because should timing change, and
> we can easily get an extra dump or compaction resulting in a different
> set of files and hence test failure. Let's rewrite the test so that
> it checks that files are actually removed using fio.path.exists().
lgtm
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-03 19:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-30 19:40 [PATCH 0/6] Get rid of the schema lock Vladimir Davydov
2019-06-30 19:40 ` [PATCH 1/6] Add ERROR_INJECT_YIELD and ERROR_INJECT_SLEEP helpers Vladimir Davydov
2019-07-03 19:12 ` Konstantin Osipov
2019-07-04 15:50 ` Vladimir Davydov
2019-06-30 19:40 ` [PATCH 2/6] Replace ERRINJ_SNAP_WRITE_ROW_TIMEOUT with ERRINJ_SNAP_WRITE_DELAY Vladimir Davydov
2019-07-03 19:13 ` Konstantin Osipov
2019-07-04 15:51 ` Vladimir Davydov
2019-06-30 19:40 ` [PATCH 3/6] Don't take schema lock for checkpointing Vladimir Davydov
2019-07-03 19:21 ` Konstantin Osipov
2019-07-03 20:05 ` Vladimir Davydov
2019-06-30 19:40 ` [PATCH 4/6] test: make vinyl/replica_rejoin more stable Vladimir Davydov
2019-07-03 19:23 ` Konstantin Osipov [this message]
2019-07-04 15:51 ` Vladimir Davydov
2019-06-30 19:40 ` [PATCH 5/6] vinyl: don't yield while logging index creation Vladimir Davydov
2019-06-30 19:40 ` [PATCH 6/6] Replace schema lock with fine-grained locking Vladimir Davydov
2019-07-03 19:35 ` Konstantin Osipov
2019-07-03 19:56 ` Vladimir Davydov
2019-07-04 8:09 ` Konstantin Osipov
2019-07-04 17:06 ` Vladimir Davydov
2019-07-08 7:40 ` Konstantin Osipov
2019-07-08 8:41 ` Vladimir Davydov
2019-07-05 8:53 ` [PATCH 0/6] Get rid of the schema lock Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703192303.GG17318@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH 4/6] test: make vinyl/replica_rejoin more stable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox