From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v1 1/1] sql: rework SQL errors of type "expected column count"
Date: Fri, 28 Jun 2019 19:15:26 +0300 [thread overview]
Message-ID: <20190628161526.dystben65fqeruji@esperanza> (raw)
In-Reply-To: <20190625141905.GA29925@tarantool.org>
On Tue, Jun 25, 2019 at 05:19:05PM +0300, Mergen Imeev wrote:
> From 98589eacdc8caf5a9db366d782338d5c3e551357 Mon Sep 17 00:00:00 2001
> Date: Sat, 18 May 2019 13:15:58 +0300
> Subject: [PATCH] sql: allow to use vectors as left value of IN operator
>
> In SQL, it is allowed to use vector expressions, that is, an
> operation that uses vectors as operands. For instance, vector
> comparison:
> SELECT (1,2,3) < (1,2,4);
>
> Accidentally, routines handling IN operator contained a bug: in
> cases where we used a vector as the left value in the IN operator,
> we received an assertion in debug build or a segmentation fault in
> release. This was due to some legacy code in which it was assumed
> that the left value of the IN operator can have only one column in
> case it is a vector. Let's fix this by allowing vectors of the
> other sizes as the left value of the IN operator and providing
> check which verifies that both sides of IN operator have the same
> dimension.
>
> Closes #4204
Pushed to master. I failed to backport this to 2.1 - sql-tap/sql-errors
test doesn't pass. Please either backport the patch by yourself or let
me know which commits should be cherry-picked beside this one.
next prev parent reply other threads:[~2019-06-28 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 10:53 [tarantool-patches] " imeevma
2019-05-19 14:38 ` [tarantool-patches] " n.pettik
2019-05-25 11:12 ` Mergen Imeev
2019-06-06 19:22 ` n.pettik
2019-06-11 8:40 ` Mergen Imeev
2019-06-25 14:19 ` Mergen Imeev
2019-06-25 17:31 ` n.pettik
2019-06-28 16:15 ` Vladimir Davydov [this message]
2019-06-29 10:33 ` Mergen Imeev
2019-07-03 9:58 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628161526.dystben65fqeruji@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re: [PATCH v1 1/1] sql: rework SQL errors of type "expected column count"' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox