Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2 2/2] decimal: expose decimal type to lua.
Date: Fri, 28 Jun 2019 18:32:34 +0300	[thread overview]
Message-ID: <20190628153234.2572vauj3iwd2t4b@esperanza> (raw)
In-Reply-To: <95ad931a1e73334ca665c840da2c0aff5b6a129c.1561731259.git.sergepetrenko@tarantool.org>

The patch looks good, but you haven't covered all error cases in
the test:

  https://coveralls.io/builds/24265960/source?filename=src/lua/decimal.c

Please make sure there's no red lines.

Also, I asked you during the previous review iteration, but you seem to
have overlooked it: can we please do anything about the trailing spaces?

On Fri, Jun 28, 2019 at 05:36:39PM +0300, Serge Petrenko wrote:
> +decimal.new(ffi.new('float', 128.5))
> +---
> +- '128.500000000000000'
> +...
> +decimal.new(ffi.new('double', 128.5))
> +---
> +- '128.500000000000000'
> +...
> +decimal.new(1)
> +---
> +- '1.000000000000000'
> +...
> +decimal.new(-1)
> +---
> +- '-1.000000000000000'
> +...
> +decimal.new(2^64)
> +---
> +- '18446744073709551616.000000000000000'
> +...

      reply	other threads:[~2019-06-28 15:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 14:36 [PATCH v2 0/2] decimal: expose decimal module to Lua Serge Petrenko
2019-06-28 14:36 ` [PATCH v2 1/2] lua/utils: add a function to register FFI metatypes Serge Petrenko
2019-06-28 14:36 ` [PATCH v2 2/2] decimal: expose decimal type to lua Serge Petrenko
2019-06-28 15:32   ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628153234.2572vauj3iwd2t4b@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH v2 2/2] decimal: expose decimal type to lua.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox