[tarantool-patches] Re: [PATCH v5 2/3] Enable GitLab CI testing

[tarantool-patches] Re: [PATCH v5 2/3] Enable GitLab CI testing

[Alexander Turenko]

I don't more have objections about the patchset, except forgotten
support of full testing of a branch.

Look however to several minor comments below.

Let's solve infrastructure questions we discussed privately, then I'll
formally approve the patchset.

WBR, Alexander Turenko.

> +release_lto:
> +  only:
> +    refs:
> +      - master

We discussed that we'll add something like /.*-full-ci/ here to allow a
developer to test a branch with all targets.

BTW, can we use a variable for 'master' here to reduce amount of changes
that will be needed to backport the patch to 2.1 and 1.10?

Is I understand right that it is the only change that will be needed
between branches?

> +###########
> +# FreeBSD #
> +###########
> +
> +deps_freebsd:
> +	sudo pkg install -y git cmake gmake gcc coreutils \
> +	readline ncurses libyaml openssl curl libunwind icu \
> +	python27 py27-pip py27-setuptools py27-daemon \
> +	py27-yaml py27-argparse py27-six py27-gevent \
> +	gdb bash

Broken indent, should be:

foo:
	foo \
		bar \
		baz

> diff --git a/test/app-tap/console.skipcond b/test/app-tap/console.skipcond
> new file mode 100644
> index 000000000..8cf610777
> --- /dev/null
> +++ b/test/app-tap/console.skipcond
> @@ -0,0 +1,8 @@
> +import os

os module is not used, the import can be removed. The same for skipconds
below.

> diff --git a/test/app/socket.skipcond b/test/app/socket.skipcond
> index 89a293f81..8cf610777 100644
> --- a/test/app/socket.skipcond
> +++ b/test/app/socket.skipcond
> @@ -1,22 +1,8 @@
> -
> -# vim: set ft=python :
> -import re
> -import os.path
> -import socket
>  import os
> -import tempfile
> -
> -test_dir = tempfile.mkdtemp(prefix='tarantool-test-socket')
> -test_path = os.path.join(test_dir, 'socket')
> +import platform
>  
> -s = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
> -try:
> -    s.bind(test_path)
> -except:
> +# Disabled on FreeBSD due to flaky fail #4271.
> +if platform.system() == 'FreeBSD':
>      self.skip = 1
>  
> -s.close()
> -
> -if os.path.exists(test_path):
> -    os.remove(test_path)
> -    os.rmdir(test_dir)
> +# vim: set ft=python:

I don't think we should remove the existing check. Instead we should add
our own at the end.