From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v4 6/6] box: introduce Lua persistent functions
Date: Tue, 25 Jun 2019 11:22:07 +0300 [thread overview]
Message-ID: <20190625082207.GA12777@atlas> (raw)
In-Reply-To: <20190624123805.35oxjrmyhzwro2wd@esperanza>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/06/24 15:40]:
The reasons I reverted this patch are:
- formally, RFC is not ready and not pushed
- the process reason why RFC is not pushed is that the contributor
didn't care to push it to completion
- the technical reason RFC is not ready because nothing is done in
the RFC to provision for persistent functions in SQL. How is a
persistent function will ever be used in SQL? What if there is a
name conflict with a built-in SQL function? What is the return
type of such a function? What are argument types and how are
they pushed to the function's call stack? It's not necessary to
implement all of this at once, but the RFC should provision good
answers for it.
--
Konstantin Osipov, Moscow, Russia
prev parent reply other threads:[~2019-06-25 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 13:57 [PATCH v4 0/6] box: rework functions machinery Kirill Shcherbatov
2019-06-23 13:57 ` [PATCH v4 1/6] box: rework func cache update machinery Kirill Shcherbatov
2019-06-24 10:22 ` Vladimir Davydov
2019-06-23 13:57 ` [PATCH v4 2/6] box: rework box_lua_{call, eval} to use input port Kirill Shcherbatov
2019-06-24 10:23 ` Vladimir Davydov
2019-06-23 13:57 ` [PATCH v4 3/6] box: rework func object as a function frontend Kirill Shcherbatov
2019-06-24 10:23 ` Vladimir Davydov
2019-06-23 13:57 ` [PATCH v4 4/6] box: export registered functions in box.func folder Kirill Shcherbatov
2019-06-24 10:25 ` Vladimir Davydov
2019-06-23 13:57 ` [PATCH v4 5/6] box: refactor box_lua_find helper Kirill Shcherbatov
2019-06-24 12:35 ` Vladimir Davydov
2019-06-23 13:57 ` [PATCH v4 6/6] box: introduce Lua persistent functions Kirill Shcherbatov
2019-06-24 12:38 ` Vladimir Davydov
2019-06-25 8:22 ` Konstantin Osipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625082207.GA12777@atlas \
--to=kostja@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v4 6/6] box: introduce Lua persistent functions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox