From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, georgy@tarantool.org
Subject: [tarantool-patches] Re: [PATCH 1/1] test: fix unit/crypto test flakiness
Date: Sun, 23 Jun 2019 21:37:52 +0300 [thread overview]
Message-ID: <20190623183752.4hl7bdduaz2puj7k@tkn_work_nb> (raw)
In-Reply-To: <f2a23fab1c4108bfa3111bce5b58a77d091c8b91.1561313617.git.v.shpilevoy@tarantool.org>
Looks good for me.
WBR, Alexander Turenko.
On Sun, Jun 23, 2019 at 08:17:30PM +0200, Vladislav Shpilevoy wrote:
> One of subtests was checking if crypto_decode returns an error
> when fails to decode. But due to randomness of the test sometimes
> it happened, that initial vector of encrypted data somehow didn't
> lead to an error. Decryption was not correct, but only in terms
> of result, not in terms of decryption algorithm. -1 was not
> returned, and diag was not set.
>
> This patch checks all the cases.
>
> Closes #4306
> ---
> Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4306-flaky-unit-crypto
> Issue: https://github.com/tarantool/tarantool/issues/4306
>
> [CC += Georgy] because he is an author of crypto module.
> [CC += Alexander] because he is an author of the issue, and revolves around
> tests.
next prev parent reply other threads:[~2019-06-23 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 18:17 [tarantool-patches] " Vladislav Shpilevoy
2019-06-23 18:37 ` Alexander Turenko [this message]
2019-06-24 17:04 ` [tarantool-patches] " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190623183752.4hl7bdduaz2puj7k@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/1] test: fix unit/crypto test flakiness' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox