Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org,
	Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [RFC] box/lua/console: Add console.fmt module
Date: Fri, 21 Jun 2019 23:07:07 +0300	[thread overview]
Message-ID: <20190621200707.GD24106@uranus> (raw)
In-Reply-To: <20190621121412.GB5998@atlas>

On Fri, Jun 21, 2019 at 03:14:12PM +0300, Konstantin Osipov wrote:
> > so we simply can't use unmodified third party engines thus
> > better to keep own much simpler (hopefully) engine.
> 
> I don't see why we can't fork serpent. But OK, provided you don't
> want serpent, what can serpent do that we're going to miss in an
> own implementation? Could you write down a summary so that we can
> analyze this ahead of time?

To be precise my complains against serpent is only one: we will
need to patch it on top to handle special symbols from "box"
(as mentioned in the original github issue box.NULL). Note that
the seializer I provided are mostly taken from Konstantin's
draft patch (see https://github.com/tarantool/tarantool/issues/3834)
which in turn is derived from
https://github.com/stevedonovan/Penlight/blob/master/lua/pl/pretty.lua
i guess.

I think currently we don't support "block" mode (or as serpent names
it -- multiline output). For simple examples of output serpent provides
same data as our console.fmt code but I think the devil in details which
I didn't discover yet.

Thus if you're _quite_ sure that we better should use serpent then I'll
try to prepare new version and we will see how it looks.

  parent reply	other threads:[~2019-06-21 20:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 21:54 [tarantool-patches] " Cyrill Gorcunov
2019-06-21  7:32 ` [tarantool-patches] " Konstantin Osipov
2019-06-21  7:36   ` Konstantin Osipov
2019-06-21  8:09     ` Cyrill Gorcunov
2019-06-21 12:11       ` Konstantin Osipov
2019-06-21 12:33         ` Cyrill Gorcunov
2019-06-21  8:16   ` Cyrill Gorcunov
2019-06-21 12:14     ` Konstantin Osipov
2019-06-21 12:41       ` Cyrill Gorcunov
2019-06-21 12:47         ` Konstantin Osipov
2019-06-21 13:17           ` Cyrill Gorcunov
2019-06-21 20:07       ` Cyrill Gorcunov [this message]
2019-06-21 20:33         ` Konstantin Osipov
2019-06-21 22:34           ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621200707.GD24106@uranus \
    --to=gorcunov@gmail.com \
    --cc=alexander.turenko@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [RFC] box/lua/console: Add console.fmt module' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox