Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org,
	Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [RFC] box/lua/console: Add console.fmt module
Date: Fri, 21 Jun 2019 15:41:30 +0300	[thread overview]
Message-ID: <20190621124130.GB24106@uranus> (raw)
In-Reply-To: <20190621121412.GB5998@atlas>

On Fri, Jun 21, 2019 at 03:14:12PM +0300, Konstantin Osipov wrote:
> 
> I don't care much about the internals here, but about the
> consistency of the console api:
> https://www.tarantool.io/en/doc/1.10/reference/reference_lua/console/

Well, I don't mind extending console api instead just need to figure
out how to put the engine into separate file (serisouly, console.lua
is already big enough).

> 
> I don't see why we can't fork serpent. But OK, provided you don't
> want serpent, what can serpent do that we're going to miss in an
> own implementation? Could you write down a summary so that we can
> analyze this ahead of time?

I will write the summary, but most important part is that they are
fetching dependency and code bloats like hell even if we don't need
most of the parts of serpent/pretty-print (initially I started with
serpent, integrated it into our code but didn't like the results much,
then I merged pretty-print engine, and again found that we need own
extensions for symbols like box.NULL which lead me to the conclusion
that if we can't use vanilla code then there is no much point to carry
these projects in our repo, better to stick small and simple functions
and extend them with time if we have to).

  reply	other threads:[~2019-06-21 12:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 21:54 [tarantool-patches] " Cyrill Gorcunov
2019-06-21  7:32 ` [tarantool-patches] " Konstantin Osipov
2019-06-21  7:36   ` Konstantin Osipov
2019-06-21  8:09     ` Cyrill Gorcunov
2019-06-21 12:11       ` Konstantin Osipov
2019-06-21 12:33         ` Cyrill Gorcunov
2019-06-21  8:16   ` Cyrill Gorcunov
2019-06-21 12:14     ` Konstantin Osipov
2019-06-21 12:41       ` Cyrill Gorcunov [this message]
2019-06-21 12:47         ` Konstantin Osipov
2019-06-21 13:17           ` Cyrill Gorcunov
2019-06-21 20:07       ` Cyrill Gorcunov
2019-06-21 20:33         ` Konstantin Osipov
2019-06-21 22:34           ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621124130.GB24106@uranus \
    --to=gorcunov@gmail.com \
    --cc=alexander.turenko@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [RFC] box/lua/console: Add console.fmt module' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox