From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Georgy Kirichenko <georgy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v4 3/9] txn: get rid of autocommit from a txn structure
Date: Thu, 20 Jun 2019 14:52:21 +0300 [thread overview]
Message-ID: <20190620115221.ns5jsvhn3xk6khsd@esperanza> (raw)
In-Reply-To: <318da5c367be4c0cfcbc049d50ec619672ac5629.1560978655.git.georgy@tarantool.org>
On Thu, Jun 20, 2019 at 12:23:10AM +0300, Georgy Kirichenko wrote:
> @@ -1313,9 +1351,17 @@ box_sequence_reset(uint32_t seq_id)
> static inline void
> box_register_replica(uint32_t id, const struct tt_uuid *uuid)
> {
> + struct txn *txn = txn_begin();
> + if (txn == NULL)
> + diag_raise();
> if (boxk(IPROTO_INSERT, BOX_CLUSTER_ID, "[%u%s]",
> - (unsigned) id, tt_uuid_str(uuid)) != 0)
> + (unsigned) id, tt_uuid_str(uuid)) != 0) {
> + txn_rollback();
> diag_raise();
> + }
> + if (txn_commit(txn) != 0)
> + diag_raise();
> + fiber_gc();
> assert(replica_by_uuid(uuid)->id == id);
> }
>
It looks like you didn't addressed any of my comments to v3,
neither did you reply to the email:
https://www.freelists.org/post/tarantool-patches/PATCH-v3-0514-txn-get-rid-of-autocommit-from-a-txn-structure,1
next prev parent reply other threads:[~2019-06-20 11:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 21:23 [tarantool-patches] [PATCH v4 0/9] Parallel applier Georgy Kirichenko
2019-06-19 21:23 ` [tarantool-patches] [PATCH v4 1/9] txn: handle fiber stop event at transaction level Georgy Kirichenko
2019-06-20 7:28 ` [tarantool-patches] " Konstantin Osipov
2019-06-20 11:39 ` [tarantool-patches] " Vladimir Davydov
2019-06-19 21:23 ` [tarantool-patches] [PATCH v4 2/9] core: latch_steal routine Georgy Kirichenko
2019-06-20 7:28 ` [tarantool-patches] " Konstantin Osipov
2019-06-20 11:53 ` [tarantool-patches] " Vladimir Davydov
2019-06-20 20:34 ` Георгий Кириченко
2019-06-19 21:23 ` [tarantool-patches] [PATCH v4 3/9] txn: get rid of autocommit from a txn structure Georgy Kirichenko
2019-06-20 7:32 ` [tarantool-patches] " Konstantin Osipov
2019-06-20 11:52 ` Vladimir Davydov [this message]
2019-06-20 20:16 ` [tarantool-patches] " Георгий Кириченко
2019-06-19 21:23 ` [tarantool-patches] [PATCH v4 4/9] txn: get rid of fiber_gc from txn_rollback Georgy Kirichenko
2019-06-20 7:43 ` [tarantool-patches] " Konstantin Osipov
2019-06-20 20:35 ` Георгий Кириченко
2019-06-20 13:03 ` [tarantool-patches] " Vladimir Davydov
2019-06-20 20:16 ` Георгий Кириченко
2019-06-19 21:23 ` [tarantool-patches] [PATCH v4 5/9] wal: a dedicated wal scheduling fiber Georgy Kirichenko
2019-06-20 7:53 ` [tarantool-patches] " Konstantin Osipov
2019-06-20 13:05 ` [tarantool-patches] " Vladimir Davydov
2019-06-19 21:23 ` [tarantool-patches] [PATCH v4 6/9] wal: introduce a journal entry finalization callback Georgy Kirichenko
2019-06-20 7:56 ` [tarantool-patches] " Konstantin Osipov
2019-06-20 14:08 ` [tarantool-patches] " Vladimir Davydov
2019-06-20 20:22 ` Георгий Кириченко
2019-06-21 7:26 ` [tarantool-patches] " Konstantin Osipov
2019-06-19 21:23 ` [tarantool-patches] [PATCH v4 7/9] txn: introduce asynchronous txn commit Georgy Kirichenko
2019-06-20 8:01 ` [tarantool-patches] " Konstantin Osipov
2019-06-20 15:00 ` [tarantool-patches] " Vladimir Davydov
2019-06-21 7:28 ` [tarantool-patches] " Konstantin Osipov
2019-06-19 21:23 ` [tarantool-patches] [PATCH v4 8/9] applier: apply transaction in parallel Georgy Kirichenko
2019-06-20 7:41 ` [tarantool-patches] " Георгий Кириченко
2019-06-20 8:07 ` Konstantin Osipov
2019-06-20 16:37 ` Vladimir Davydov
2019-06-20 20:33 ` Георгий Кириченко
2019-06-21 8:36 ` Vladimir Davydov
2019-06-20 8:06 ` Konstantin Osipov
2019-06-19 21:23 ` [tarantool-patches] [PATCH v4 9/9] test: fix flaky test Georgy Kirichenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620115221.ns5jsvhn3xk6khsd@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v4 3/9] txn: get rid of autocommit from a txn structure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox