[tarantool-patches] Re: [PATCH] vinyl: don't yield in on_commit and on_rollback triggers

[Konstantin Osipov <kostja@tarantool.org>]

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/06/16 16:11]:

Basically the patch is LGTM but I would not use a mempool
vy_log_tx but more strongly  a a region for vy_log records - these
are rare events (less than a handful a second per instance) and
using a malloc for such is entirely justified.

On the other hand I don't see any harm from using these (memory is
not pinned for along period of time, for example), so please feel
free to not bother with the comment.

> +vy_log_flusher_func(va_list va)

The convention is that we simply write _f for fiber functions at the
end.

I also did not find the place where you cancel or kill the fiber -
you assume it runs forever - please document it, since otherwise
the infinite fiber loop looks confusing.


-- 
Konstantin Osipov, Moscow, Russia