Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Stanislav Zudin <szudin@tarantool.org>
Cc: tarantool-patches@freelists.org, alexander.turenko@tarantool.org
Subject: Re: [PATCH v3] core: Non-blocking io.popen
Date: Wed, 19 Jun 2019 12:41:48 +0300	[thread overview]
Message-ID: <20190619094148.xbrqobqdgvpgntwb@esperanza> (raw)
In-Reply-To: <20190617185459.13193-1-szudin@tarantool.org>

On Mon, Jun 17, 2019 at 09:54:59PM +0300, Stanislav Zudin wrote:
>  src/CMakeLists.txt              |   1 +
>  src/lua/fio.lua                 |  50 +++--------
>  src/lua/init.c                  |   2 +
>  src/lua/lua_signal.c            | 155 ++++++++++++++++++++++++++++++++
>  src/lua/lua_signal.h            |  45 ++++++++++
>  test/app-tap/fio_popen.test.lua |  11 +--
>  6 files changed, 220 insertions(+), 44 deletions(-)
>  create mode 100644 src/lua/lua_signal.c
>  create mode 100644 src/lua/lua_signal.h

Looks like you forgot to squash commits. Please do and rebase on
the current master commit.

  reply	other threads:[~2019-06-19  9:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 18:54 Stanislav Zudin
2019-06-19  9:41 ` Vladimir Davydov [this message]
2019-06-19 11:36   ` Stanislav Zudin
2019-06-21 12:31 ` Vladimir Davydov
2019-07-02  6:56   ` Stanislav Zudin
  -- strict thread matches above, loose matches on Subject: below --
2019-06-13 12:02 Stanislav Zudin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190619094148.xbrqobqdgvpgntwb@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=alexander.turenko@tarantool.org \
    --cc=szudin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH v3] core: Non-blocking io.popen' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox