From: Mergen Imeev <imeevma@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 00/28] sql: Remove SQL error system
Date: Sat, 15 Jun 2019 13:08:32 +0300 [thread overview]
Message-ID: <20190615100832.GJ32365@tarantool.org> (raw)
In-Reply-To: <24f3fffc-2fa3-0a56-7419-2e57aa2f5f03@tarantool.org>
Hi! Thank you for review! I squashed all commits with the title
"Review fix". I also rebased the branch to the current master.
There have been some changes due to issue 3978 (commit
"sql: cleanup code from outdated macros"). However, I am not sure
that these changes are enough to send a new version. Instead,
I just answered patches with a review. Since both issues usually
simply remove part of the unused code, in most cases the patches
get shorter after the rebase.
On Fri, Jun 14, 2019 at 12:24:43AM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patchset!
>
> Please, consider my review comments and fixes for some of
> the patches in responses to them.
>
> Also I've pushed on top of the branch a new commit removing
> a couple of another error codes. It is not for squash - just
> a new commit.
>
> On 10/06/2019 16:56, imeevma@tarantool.org wrote:
> > This patch-set removes unused and unnecessary code of SQL error
> > system.
> >
> > Mergen Imeev (26):
> > sql: remove field zErrMsg from struct Vdbe
> > sql: remove field pErr from struct sql
> > sql: remove field errCode from struct sql
> > sql: remove sqlError() and remove sqlErrorWithMsg()
> > sql: remove unused functions of SQL error system
> > sql: disable lookaside system
> > sql: remove SQL_OK error/status code
> > sql: remove SQL_PERM, SQL_WARNING, SQL_ABORT errcodes
> > sql: remove SQL_CANTOPEN errcode
> > sql: remove SQL_NOTFOUND error/status code
> > sql: remove SQL_LOCKED errcode
> > sql: remove SQL_FULL errcode
> > sql: remove SQL_MISUSE errcode
> > sql: remove SQL_RANGE errcode
> > sql: remove SQL_SCHEMA errcode
> > sql: remove SQL_TOOBIG errcode
> > sql: remove SQL_BUSY errcode
> > sql: remove SQL_CONSTRAINT errcode
> > sql: remove SQL_ERROR errcode
> > sql: remove SQL_NOMEM errcode
> > sql: remove SQL_IOERR errcode
> > sql: remove SQL_TARANTOOL_ERROR errcode
> > sql: remove field errMask from struct sql
> > sql: replace rc by is_aborted in struct VDBE
> > sql: remove sql_log()
> > sql: remove function sqlApiExit()
> >
> > Nikita Pettik (2):
> > sql: cleanup of legacy memory management system
> > sql: make function return void instead of int
> >
> > src/box/bind.c | 37 +---
> > src/box/ck_constraint.c | 4 +-
> > src/box/execute.c | 6 +-
> > src/box/lua/lua_sql.c | 2 +-
> > src/box/sql.c | 104 ++++------
> > src/box/sql/analyze.c | 2 +-
> > src/box/sql/build.c | 6 +-
> > src/box/sql/cursor.c | 4 +-
> > src/box/sql/date.c | 14 +-
> > src/box/sql/expr.c | 7 +-
> > src/box/sql/fault.c | 4 +-
> > src/box/sql/fk_constraint.c | 8 +-
> > src/box/sql/func.c | 16 +-
> > src/box/sql/global.c | 3 -
> > src/box/sql/insert.c | 9 +-
> > src/box/sql/legacy.c | 21 +-
> > src/box/sql/main.c | 266 ++++---------------------
> > src/box/sql/malloc.c | 445 +-----------------------------------------
> > src/box/sql/os.c | 14 +-
> > src/box/sql/os_unix.c | 281 ++++++++------------------
> > src/box/sql/prepare.c | 73 ++-----
> > src/box/sql/printf.c | 36 +---
> > src/box/sql/resolve.c | 3 +-
> > src/box/sql/select.c | 61 +++---
> > src/box/sql/sqlInt.h | 173 +---------------
> > src/box/sql/status.c | 182 -----------------
> > src/box/sql/tarantoolInt.h | 11 +-
> > src/box/sql/tokenize.c | 5 -
> > src/box/sql/trigger.c | 2 +-
> > src/box/sql/util.c | 162 ---------------
> > src/box/sql/vdbe.c | 111 ++++-------
> > src/box/sql/vdbeInt.h | 13 +-
> > src/box/sql/vdbeapi.c | 357 +++++++++------------------------
> > src/box/sql/vdbeaux.c | 217 ++++++--------------
> > src/box/sql/vdbemem.c | 120 ++++++------
> > src/box/sql/vdbesort.c | 274 ++++++++++++--------------
> > src/box/sql/where.c | 108 +++++-----
> > src/box/sql/whereexpr.c | 3 +-
> > test/sql/bind.result | 8 +
> > test/sql/bind.test.lua | 3 +
> > test/sql/func-recreate.result | 3 +-
> > 41 files changed, 726 insertions(+), 2452 deletions(-)
> >
next prev parent reply other threads:[~2019-06-15 10:08 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 13:56 [tarantool-patches] " imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 01/28] sql: remove field zErrMsg from struct Vdbe imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 02/28] sql: remove field pErr from struct sql imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 03/28] sql: remove field errCode " imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 04/28] sql: remove sqlError() and remove sqlErrorWithMsg() imeevma
2019-06-13 22:25 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-15 9:45 ` Mergen Imeev
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 05/28] sql: remove unused functions of SQL error system imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 06/28] sql: disable lookaside system imeevma
2019-06-13 22:25 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-15 9:47 ` Mergen Imeev
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 07/28] sql: remove SQL_OK error/status code imeevma
2019-06-13 22:24 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-15 9:52 ` Mergen Imeev
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 08/28] sql: remove SQL_PERM, SQL_WARNING, SQL_ABORT errcodes imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 09/28] sql: remove SQL_CANTOPEN errcode imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 10/28] sql: remove SQL_NOTFOUND error/status code imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 11/28] sql: remove SQL_LOCKED errcode imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 12/28] sql: remove SQL_FULL errcode imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 13/28] sql: remove SQL_MISUSE errcode imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 14/28] sql: remove SQL_RANGE errcode imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 15/28] sql: remove SQL_SCHEMA errcode imeevma
2019-06-13 22:24 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-15 9:55 ` Mergen Imeev
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 16/28] sql: remove SQL_TOOBIG errcode imeevma
2019-06-13 22:24 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-15 9:57 ` Mergen Imeev
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 17/28] sql: remove SQL_BUSY errcode imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 18/28] sql: remove SQL_CONSTRAINT errcode imeevma
2019-06-13 22:24 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-15 10:00 ` Mergen Imeev
2019-06-18 20:40 ` Vladislav Shpilevoy
2019-06-19 8:02 ` Mergen Imeev
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 19/28] sql: remove SQL_ERROR errcode imeevma
2019-06-10 13:56 ` [tarantool-patches] [PATCH v1 20/28] sql: remove SQL_NOMEM errcode imeevma
2019-06-13 22:24 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-15 10:01 ` Mergen Imeev
2019-06-10 13:57 ` [tarantool-patches] [PATCH v1 21/28] sql: remove SQL_IOERR errcode imeevma
2019-06-10 13:57 ` [tarantool-patches] [PATCH v1 22/28] sql: remove SQL_TARANTOOL_ERROR errcode imeevma
2019-06-10 13:57 ` [tarantool-patches] [PATCH v1 23/28] sql: remove field errMask from struct sql imeevma
2019-06-10 13:57 ` [tarantool-patches] [PATCH v1 24/28] sql: replace rc by is_aborted in struct VDBE imeevma
2019-06-10 13:57 ` [tarantool-patches] [PATCH v1 25/28] sql: remove sql_log() imeevma
2019-06-13 22:24 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-15 10:02 ` Mergen Imeev
2019-06-10 13:57 ` [tarantool-patches] [PATCH v1 26/28] sql: cleanup of legacy memory management system imeevma
2019-06-13 22:24 ` [tarantool-patches] " Vladislav Shpilevoy
2019-06-15 10:04 ` Mergen Imeev
2019-06-18 20:40 ` Vladislav Shpilevoy
2019-06-19 8:04 ` Mergen Imeev
2019-06-10 13:57 ` [tarantool-patches] [PATCH v1 27/28] sql: make function return void instead of int imeevma
2019-06-10 13:57 ` [tarantool-patches] [PATCH v1 28/28] sql: remove function sqlApiExit() imeevma
2019-06-11 10:00 ` [tarantool-patches] Re: [PATCH v1 00/28] sql: Remove SQL error system Imeev Mergen
2019-06-13 22:24 ` Vladislav Shpilevoy
2019-06-15 10:08 ` Mergen Imeev [this message]
2019-06-19 19:11 ` Vladislav Shpilevoy
2019-06-20 16:08 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190615100832.GJ32365@tarantool.org \
--to=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 00/28] sql: Remove SQL error system' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox